Skip to content

[DS-6660][Improvement] Change the registry default timeout#6663

Merged
lenboo merged 3 commits intoapache:devfrom
caishunfeng:zk_session
Nov 4, 2021
Merged

[DS-6660][Improvement] Change the registry default timeout#6663
lenboo merged 3 commits intoapache:devfrom
caishunfeng:zk_session

Conversation

@caishunfeng
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng commented Nov 2, 2021

this pr close #6660

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6663 (a6c0bf0) into dev (900cf3a) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6663      +/-   ##
============================================
- Coverage     38.47%   38.40%   -0.07%     
- Complexity     3223     3225       +2     
============================================
  Files           646      646              
  Lines         25886    25936      +50     
  Branches       2808     2817       +9     
============================================
+ Hits           9959     9961       +2     
- Misses        15013    15063      +50     
+ Partials        914      912       -2     
Impacted Files Coverage Δ
...gin/registry/zookeeper/ZookeeperConfiguration.java 100.00% <100.00%> (ø)
...heduler/spi/plugin/DolphinPluginManagerConfig.java 0.00% <0.00%> (ø)
...dolphinscheduler/remote/future/ResponseFuture.java 83.05% <0.00%> (+1.69%) ⬆️
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900cf3a...a6c0bf0. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@caishunfeng
Copy link
Copy Markdown
Contributor Author

PTAL @lenboo @CalvinKirs

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo added this to the 2.0.0-release milestone Nov 4, 2021
@lenboo lenboo merged commit 1ebab35 into apache:dev Nov 4, 2021
lenboo pushed a commit to lenboo/dolphinscheduler that referenced this pull request Nov 8, 2021
* [DS-6660][Improvement] Change the registry default timeout

* [DS-6660][Improvement] Change the registry default timeout

* fix Double to Integer

Co-authored-by: caishunfeng <534328519@qq.com>
@caishunfeng caishunfeng deleted the zk_session branch December 15, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Server] Change the registry session timeout

4 participants