Skip to content

[DS-6653][Server] fix netty create too many channels#6654

Merged
zhuangchong merged 1 commit intoapache:devfrom
caishunfeng:fix_netty_channel
Nov 1, 2021
Merged

[DS-6653][Server] fix netty create too many channels#6654
zhuangchong merged 1 commit intoapache:devfrom
caishunfeng:fix_netty_channel

Conversation

@caishunfeng
Copy link
Copy Markdown
Contributor

this pr close #6653

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 1, 2021

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 38.48%. Comparing base (3a8b809) to head (de29d8c).
Report is 3224 commits behind head on dev.

Files with missing lines Patch % Lines
...org/apache/dolphinscheduler/remote/utils/Host.java 14.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6654      +/-   ##
============================================
- Coverage     38.49%   38.48%   -0.01%     
- Complexity     3223     3224       +1     
============================================
  Files           646      646              
  Lines         25874    25881       +7     
  Branches       2805     2807       +2     
============================================
+ Hits           9959     9960       +1     
- Misses        15002    15008       +6     
  Partials        913      913              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

5.3% 5.3% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit daca3ba into apache:dev Nov 1, 2021
lenboo pushed a commit that referenced this pull request Nov 1, 2021
Co-authored-by: caishunfeng <534328519@qq.com>
@caishunfeng caishunfeng deleted the fix_netty_channel branch December 15, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Server] Netty client create too many channel and make busy network

4 participants