[Feature-#3049] Alert Plugin Design(merge alert_plugin_design to dev) by CalvinKirs · Pull Request #4495 · apache/dolphinscheduler

CalvinKirs · 2021-01-19T11:03:10Z

No description provided.

* [feature-3665][ui]Add element-ui * add license

* [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo (#3683) * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [feature][ui] Add alarm instance page * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix

…r spi and alert plugin implement (#3601) * DS SPI * Add DolphinScheduler SPI , and rebuilt the code of the Alert plug-in based on SPI * Add DolphinScheduler SPI , and rebuilt the code of the Alert plug-in based on SPI * add TODO * delete * compile * spi commit * Plugin Alert * fix some bug * add todo * change web ui from alpacajs to form-create * remove module * add plugin schema * add license header * update alert and spi module version * update the alert plugin sub module version * comment the maven.local.repository param * move utils from spi to common module * add license header * add license header and delete some chinese comment * update spi packages * delete no use alert_xx.properties * update mysql.connector.version back to 5.1.34 * delete no use comment in pom.xml * update email stmp password * add license * add semicolon to sql/upgrade/1.4.0_schema/mysql/dolphinscheduler_ddl.sql file * format the code style * format new clase file with checkstyle * update plugin params to Builder model * move JSONUtils to SPI because plugin can not dependency common module * move JSONUtils to SPI because plugin can not dependency common module * delete collection dependency * replace PluginParamsTransfer to spi PluginParamsTransfer * update dolphinscheduler-maven-plugin to 1.0.0 * update license * update apache-rat-plugin add exclude '.iml' file * check license * ArtifactResolver only use in development and configPlugins is not empty * ArtifactResolver only use in development and configPlugins is not empty * ArtifactResolver only use in development and configPlugins is not empty * default datasource should be postgresql * add license files * add license files * postgresql port should be 5432 * postgresql test * mv show_type to spi add license header to AlertConstants * check style fix * copy check style file from branch dev * alert show_type set by plugin * alert show_type set by plugin * add PluginDefineMapper to dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/registry/DependencyConfig.java * add Bean to TaskCallbackServiceTestConfig * add Bean to TaskCallbackServiceTestConfig * fix check style * check style fix * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * fix check style * [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo (#3683) * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * check style fix * rollback test change * rollback test change * rollback dao pom change * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * add ut to pom.xml * add upgrade schema to global schema * fix ut failed * fix ut failed * fix ut failed * fix ut failed * add test EmailAlertPluginTest to pom.xml * fix ut failed * fix ut failed * fix check style * update license header to presto license header * presto license header not check * fix ut coverage * fix ut coverage * fix ut * fix ut * fix ut * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage Co-authored-by: break60 <790061044@qq.com>

* [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo (#3683) * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [feature][ui] Add alarm instance page * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [feature][ui]Alert plugin design (#3734) * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo (#3683) * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [feature][ui] Add alarm instance page * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [Feature-3189][alert,spi,dao,plugin-api] base code of dolphinscheduler spi and alert plugin implement (#3601) * DS SPI * Add DolphinScheduler SPI , and rebuilt the code of the Alert plug-in based on SPI * Add DolphinScheduler SPI , and rebuilt the code of the Alert plug-in based on SPI * add TODO * delete * compile * spi commit * Plugin Alert * fix some bug * add todo * change web ui from alpacajs to form-create * remove module * add plugin schema * add license header * update alert and spi module version * update the alert plugin sub module version * comment the maven.local.repository param * move utils from spi to common module * add license header * add license header and delete some chinese comment * update spi packages * delete no use alert_xx.properties * update mysql.connector.version back to 5.1.34 * delete no use comment in pom.xml * update email stmp password * add license * add semicolon to sql/upgrade/1.4.0_schema/mysql/dolphinscheduler_ddl.sql file * format the code style * format new clase file with checkstyle * update plugin params to Builder model * move JSONUtils to SPI because plugin can not dependency common module * move JSONUtils to SPI because plugin can not dependency common module * delete collection dependency * replace PluginParamsTransfer to spi PluginParamsTransfer * update dolphinscheduler-maven-plugin to 1.0.0 * update license * update apache-rat-plugin add exclude '.iml' file * check license * ArtifactResolver only use in development and configPlugins is not empty * ArtifactResolver only use in development and configPlugins is not empty * ArtifactResolver only use in development and configPlugins is not empty * default datasource should be postgresql * add license files * add license files * postgresql port should be 5432 * postgresql test * mv show_type to spi add license header to AlertConstants * check style fix * copy check style file from branch dev * alert show_type set by plugin * alert show_type set by plugin * add PluginDefineMapper to dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/registry/DependencyConfig.java * add Bean to TaskCallbackServiceTestConfig * add Bean to TaskCallbackServiceTestConfig * fix check style * check style fix * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * fix check style * [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo (#3683) * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * check style fix * rollback test change * rollback test change * rollback dao pom change * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * add ut to pom.xml * add upgrade schema to global schema * fix ut failed * fix ut failed * fix ut failed * fix ut failed * add test EmailAlertPluginTest to pom.xml * fix ut failed * fix ut failed * fix check style * update license header to presto license header * presto license header not check * fix ut coverage * fix ut coverage * fix ut * fix ut * fix ut * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage Co-authored-by: break60 <790061044@qq.com> * The tenant management module ui is replaced with element-ui * fix * fix * fix * fix * fix * modify * fix Co-authored-by: gaojun2048 <32193458+gaojun2048@users.noreply.github.com>

* [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [feature][ui]Alert plugin design (#3734) * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo (#3683) * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [feature][ui] Add alarm instance page * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * [Feature-3189][alert,spi,dao,plugin-api] base code of dolphinscheduler spi and alert plugin implement (#3601) * DS SPI * Add DolphinScheduler SPI , and rebuilt the code of the Alert plug-in based on SPI * Add DolphinScheduler SPI , and rebuilt the code of the Alert plug-in based on SPI * add TODO * delete * compile * spi commit * Plugin Alert * fix some bug * add todo * change web ui from alpacajs to form-create * remove module * add plugin schema * add license header * update alert and spi module version * update the alert plugin sub module version * comment the maven.local.repository param * move utils from spi to common module * add license header * add license header and delete some chinese comment * update spi packages * delete no use alert_xx.properties * update mysql.connector.version back to 5.1.34 * delete no use comment in pom.xml * update email stmp password * add license * add semicolon to sql/upgrade/1.4.0_schema/mysql/dolphinscheduler_ddl.sql file * format the code style * format new clase file with checkstyle * update plugin params to Builder model * move JSONUtils to SPI because plugin can not dependency common module * move JSONUtils to SPI because plugin can not dependency common module * delete collection dependency * replace PluginParamsTransfer to spi PluginParamsTransfer * update dolphinscheduler-maven-plugin to 1.0.0 * update license * update apache-rat-plugin add exclude '.iml' file * check license * ArtifactResolver only use in development and configPlugins is not empty * ArtifactResolver only use in development and configPlugins is not empty * ArtifactResolver only use in development and configPlugins is not empty * default datasource should be postgresql * add license files * add license files * postgresql port should be 5432 * postgresql test * mv show_type to spi add license header to AlertConstants * check style fix * copy check style file from branch dev * alert show_type set by plugin * alert show_type set by plugin * add PluginDefineMapper to dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/registry/DependencyConfig.java * add Bean to TaskCallbackServiceTestConfig * add Bean to TaskCallbackServiceTestConfig * fix check style * check style fix * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * fix check style * [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo (#3683) * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * check style fix * rollback test change * rollback test change * rollback dao pom change * [feature-3665][ui]Add element-ui (#3666) * [feature-3665][ui]Add element-ui * add license * Add form-create plug-in and alarm group management add sample demo * Modify node version * fix * fix * add ut to pom.xml * add upgrade schema to global schema * fix ut failed * fix ut failed * fix ut failed * fix ut failed * add test EmailAlertPluginTest to pom.xml * fix ut failed * fix ut failed * fix check style * update license header to presto license header * presto license header not check * fix ut coverage * fix ut coverage * fix ut * fix ut * fix ut * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage * fix ut coverage Co-authored-by: break60 <790061044@qq.com> * [feature#3356] alert-spi support DingTalk this closes # 3356 * add test * code style * we chat alert * support we chat alert * support we chat alert * support we chat alert,update ding talk alert * code style * add test * code style * clean old code * clean old code * code smell * code style * add test * simple config * code style * code style * code style * delete old file * fix log content error Co-authored-by: break60 <790061044@qq.com> Co-authored-by: gaojun2048 <32193458+gaojun2048@users.noreply.github.com>

[Feature-3754][Alert] Alert module support service for other service invoke

this closes #4029

[FEATURE#4029] alert spi support script alert

code style

codecov-io · 2021-01-20T01:41:35Z

Codecov Report

Merging #4495 (432d121) into dev (690e4ea) will increase coverage by 1.01%.
The diff coverage is 47.99%.

@@             Coverage Diff              @@
##                dev    #4495      +/-   ##
============================================
+ Coverage     43.58%   44.60%   +1.01%     
- Complexity     3202     3323     +121     
============================================
  Files           471      527      +56     
  Lines         21765    22811    +1046     
  Branches       2640     2669      +29     
============================================
+ Hits           9487    10175     +688     
- Misses        11376    11719     +343     
- Partials        902      917      +15

Impacted Files	Coverage Δ	Complexity Δ
...ler/plugin/alert/dingtalk/DingTalkAlertPlugin.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...plugin/alert/dingtalk/DingTalkParamsConstants.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...scheduler/plugin/alert/email/EmailAlertPlugin.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...eduler/plugin/alert/email/MailParamsConstants.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...ler/plugin/alert/email/template/AlertTemplate.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...heduler/plugin/alert/script/ScriptAlertPlugin.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...ler/plugin/alert/script/ScriptParamsConstants.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...uler/plugin/alert/wechat/WeChatAlertConstants.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...lugin/alert/wechat/WeChatAlertParamsConstants.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...heduler/plugin/alert/wechat/WeChatAlertPlugin.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690e4ea...432d121. Read the comment docs.

EricJoy2048

+1

zhuangchong · 2021-01-22T02:08:28Z

+1

# Conflicts: # dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java

sonarqubecloud · 2021-01-22T02:32:44Z

SonarCloud Quality Gate failed.

0 Bugs
12 Vulnerabilities
0 Security Hotspots
141 Code Smells

47.3% Coverage
1.9% Duplication

… to dev) (#4495)" (#4535) This reverts commit 0c8d08c

break60 and others added 30 commits October 12, 2020 15:28

[feature-3665][ui]Add element-ui (#3666)

543aac5

* [feature-3665][ui]Add element-ui * add license

Add form-create plug-in and alarm group management add sample demo

ab884df

Modify node version

bbfe5c1

fix

1057e6b

fix

a7a928b

the alert module support service.

2df6ecb

the alert module support service.

30d75f2

Delete blank lines.

36cfcc4

add code checkstyle.

a263455

Solve the sonar bug.

5c1561a

Re-execute build.

3341317

add test.

500d481

update ut.

0fdb001

add test class.

54802bb

update test.

72942ac

Merge pull request #3979 from zhuangchong/alert_spi_support_sync_service

c61e536

[Feature-3754][Alert] Alert module support service for other service invoke

[FEATURE#4029] alert spi support script alert

f4ef86c

this closes #4029

code style

4c7743f

code smell

05eabda

add test

e4641da

code style

03ed107

code smell

5b14319

code style

66afe5a

fix name error

63522ad

Merge pull request #4063 from CalvinKirs/alert_script

c3695a0

[FEATURE#4029] alert spi support script alert

init sms plugin

91eb42d

CalvinKirs added 9 commits January 14, 2021 19:21

add name field provide to ui

ca86a65

fix send error

7162165

add ui

0b8ea92

merge dev to alert_spi

cf9ea29

delete useless constant definitions

d346f93

code style

code style

03887cd

fix license head error

cc134aa

fix ut error

88522fd

fix ut error

87db67b

CalvinKirs added 12 commits January 20, 2021 09:51

del unused jar

5f0e5aa

import alert-plugin

aa6a739

upgrade jboss-logging

eebc55d

upgrade jboss-logging

61f6a06

fix ut error

1d01b6f

fix Vulnerabilities

03b7a43

fix Vulnerabilities

6878d3d

fix Vulnerabilities

590dda8

code smell

e9f33bf

fix Vulnerabilities

d0c9bf8

add public constructors

9881333

fix Vulnerabilities

432d121

EricJoy2048 approved these changes Jan 21, 2021

View reviewed changes

CalvinKirs added 2 commits January 22, 2021 10:12

resolve conflicts

3af9ebc

Merge branch 'dev' into fix_alert_spi

85ef13f

# Conflicts: # dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java

EricJoy2048 merged commit 0c8d08c into apache:dev Jan 22, 2021

CalvinKirs mentioned this pull request Jan 22, 2021

Revert "[Feature-#3049] Alert Plugin Design(merge alert_plugin_design… #4535

Merged

EricJoy2048 pushed a commit that referenced this pull request Jan 22, 2021

Revert "[Feature-#3049] Alert Plugin Design(merge alert_plugin_design…

ab95b16

… to dev) (#4495)" (#4535) This reverts commit 0c8d08c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature-#3049] Alert Plugin Design(merge alert_plugin_design to dev)#4495

[Feature-#3049] Alert Plugin Design(merge alert_plugin_design to dev)#4495
EricJoy2048 merged 76 commits intoapache:devfrom
CalvinKirs:fix_alert_spi

CalvinKirs commented Jan 19, 2021

Uh oh!

codecov-io commented Jan 20, 2021 •

edited

Loading

Uh oh!

EricJoy2048 left a comment

Uh oh!

zhuangchong commented Jan 22, 2021

Uh oh!

sonarqubecloud bot commented Jan 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

CalvinKirs commented Jan 19, 2021

Uh oh!

codecov-io commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

EricJoy2048 left a comment

Choose a reason for hiding this comment

Uh oh!

zhuangchong commented Jan 22, 2021

Uh oh!

sonarqubecloud bot commented Jan 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov-io commented Jan 20, 2021 •

edited

Loading