Skip to content

[FIX-3177]Task time parameter parsing error#4237

Merged
xingchun-chen merged 5 commits intoapache:devfrom
CalvinKirs:fix_date_convert_null
Dec 21, 2020
Merged

[FIX-3177]Task time parameter parsing error#4237
xingchun-chen merged 5 commits intoapache:devfrom
CalvinKirs:fix_date_convert_null

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo
Copy link
Copy Markdown
Contributor

lenboo commented Dec 16, 2020

link the issue (#3177)

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4237 (9d6ad4d) into dev (d7b3936) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #4237      +/-   ##
============================================
- Coverage     42.95%   42.92%   -0.03%     
+ Complexity     3134     3131       -3     
============================================
  Files           464      464              
  Lines         21607    21608       +1     
  Branches       2610     2611       +1     
============================================
- Hits           9282     9276       -6     
- Misses        11436    11438       +2     
- Partials        889      894       +5     
Impacted Files Coverage Δ Complexity Δ
.../dolphinscheduler/common/utils/ParameterUtils.java 43.51% <50.00%> (-1.35%) 16.00 <0.00> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) 3.00% <0.00%> (-1.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.00% <0.00%> (-2.78%) 9.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b3936...9d6ad4d. Read the comment docs.

@xingchun-chen xingchun-chen added this to the 1.3.4-release milestone Dec 16, 2020
xingchun-chen added a commit that referenced this pull request Dec 16, 2020
@sonarqubecloud
Copy link
Copy Markdown

@CalvinKirs
Copy link
Copy Markdown
Member Author

image
Sonar cannot count the coverage of powermock. When preForTest contains test classes.

@xingchun-chen
Copy link
Copy Markdown
Contributor

+1

@xingchun-chen xingchun-chen removed this from the 1.3.4-release milestone Dec 18, 2020
@xingchun-chen xingchun-chen merged commit 5544734 into apache:dev Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants