Skip to content

[Improvement][server] unit test for SubProcessTask with PowerMockRunner#3632

Merged
Jave-Chen merged 4 commits intoapache:devfrom
hsupu:dev-test-subproc-task-powermockito
Sep 3, 2020
Merged

[Improvement][server] unit test for SubProcessTask with PowerMockRunner#3632
Jave-Chen merged 4 commits intoapache:devfrom
hsupu:dev-test-subproc-task-powermockito

Conversation

@hsupu
Copy link
Copy Markdown
Contributor

@hsupu hsupu commented Aug 31, 2020

What is the purpose of the pull request

Brief change log

  • Add a test for SubProcessTaskExecThread and enable it in pom.xml
  • Use PowerMockRunner to mock static class Stopper

Verify this pull request

  • Added org.apache.dolphinscheduler.server.master.SubProcessTaskTest
  • Tested locally.

@hsupu hsupu changed the title [Improvement][server] unit test for SubProcessTask with PowerMockitoRunner [Improvement][server] unit test for SubProcessTask with PowerMockRunner Aug 31, 2020
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangyichao-mango
Copy link
Copy Markdown
Contributor

+1

Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@Jave-Chen Jave-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants