[Improvement][server] unit test for SubProcessTask#3587
Closed
hsupu wants to merge 1 commit intoapache:devfrom
Closed
[Improvement][server] unit test for SubProcessTask#3587hsupu wants to merge 1 commit intoapache:devfrom
hsupu wants to merge 1 commit intoapache:devfrom
Conversation
yangyichao-mango
requested changes
Aug 25, 2020
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/thread/Stopper.java
Outdated
Show resolved
Hide resolved
fe85fcc to
9a21bb6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
yangyichao-mango
requested changes
Sep 3, 2020
Comment on lines
+99
to
+101
| if (!Stopper.isRunning()) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Will it directly return because the global Stopper.isRunning() return false?
Contributor
|
Please resolve conflicts. |
Contributor
Author
|
alternative to #3632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
add the unit test for SubProcessTask
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
org.apache.dolphinscheduler.server.master.SubProcessTaskTest