add clickhouse && fix db connection leak issue#36
Merged
davidzollo merged 3 commits intoapache:devfrom Apr 12, 2019
Merged
Conversation
davidzollo
reviewed
Apr 12, 2019
Contributor
davidzollo
left a comment
There was a problem hiding this comment.
very good , please add unit test class, refer to SqlExecutorTest.java, thx!
Member
Author
updated unit test accordingly, please see latest commit. thanks! |
Technoboy-
added a commit
that referenced
this pull request
Nov 22, 2019
|
SonarCloud Quality Gate failed.
|
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Aug 13, 2022
(cherry picked from commit 47b5006)
|
SonarCloud Quality Gate failed. |
|
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.