Skip to content

[Feature]modify some cases from rockxsj:Feature-presto to add presto datasource support #3468

Merged
davidzollo merged 5 commits intoapache:devfrom
dengc367:dev
Aug 17, 2020
Merged

[Feature]modify some cases from rockxsj:Feature-presto to add presto datasource support #3468
davidzollo merged 5 commits intoapache:devfrom
dengc367:dev

Conversation

@dengc367
Copy link
Copy Markdown
Contributor

@dengc367 dengc367 commented Aug 12, 2020 •
edited
Loading

Tips

What is the purpose of the pull request

I have merged the presto feature from [Feature]add presto datasource support and modify some files to fix two bugs in that presto feature branch.

Brief change log

     new file:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/PrestoDataSource.java
    modified:   .gitignore
    modified:   dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
    modified:   dolphinscheduler-common/pom.xml
    modified:   dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
    modified:   dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/DbType.java
    modified:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/BaseDataSource.java
    modified:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/DataSourceFactory.java
    modified:   dolphinscheduler-ui/src/js/conf/home/pages/datasource/pages/list/_source/createDataSource.vue
    modified:   dolphinscheduler-ui/src/js/conf/home/store/dag/state.js
    modified:   dolphinscheduler-ui/src/js/conf/home/store/datasource/actions.js
    modified:   pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

dengc367 and others added 4 commits August 4, 2020 10:55
@dengc367
Feature presto (#1)
b5f4cb9 
* * add presto datasource support
update .gitigonre to igonre some files

* * use another presto driver

* * add LICENSE files about presto-jdbc

* * just for test sonar

Co-authored-by: rockxsj <junjun@mgtv.com>
@dengc367
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
503ed0b 
…duler into dev
@dengc367
modify the io.prestosql.jdbc.PrestoDriver to com.facebook.presto.jdbc…
1647df5 
….PrestoDriver
@dengc367
add presto connection in sql node
3635cc0
This was referenced Aug 12, 2020
Merged
Closed
@dengc367
Copy link
Copy Markdown
Contributor Author

dengc367 commented Aug 12, 2020 •
edited
Loading

this modified feature was tested in our test environment and are using the feature online, so I am going to pull request it to feedback & contribute to the dolphinscheduler community. thanks @rockxsj to contribute the base code.

@dengc367
Copy link
Copy Markdown
Contributor Author

dengc367 commented Aug 12, 2020 •
edited
Loading

who can merge this feature to the dev branch. thanks. @dailidong

davidzollo
davidzollo approved these changes Aug 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo added this to the 1.4.0 milestone Aug 13, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Aug 14, 2020

Please solve conficting files locally,
by the way, I have merged the PR #3308 first, because we use squash merge, can't see his PR submission if I directly merge this PR
last, thanks for your first contribution, if you need any help , please contact my wechat(510570367), when added , please tell me your github id, thx

@dengc367
Copy link
Copy Markdown
Contributor Author

dengc367 commented Aug 14, 2020

@dailidong I have solved the conflicting files, now. you can merge now. thank @rockxsj for the initial contribution.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
83.3% 83.3% Duplication

@davidzollo davidzollo merged commit ad89f43 into apache:dev Aug 17, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Aug 17, 2020

good job，thanks for your first contribution, please contact my wechat(510570367) , when added, please tell your github id, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dengc367 @davidzollo