Skip to content

[Feature]add presto datasource support#3308

Merged
davidzollo merged 5 commits intoapache:devfrom
rockxsj:Feature-presto
Aug 14, 2020
Merged

[Feature]add presto datasource support#3308
davidzollo merged 5 commits intoapache:devfrom
rockxsj:Feature-presto

Conversation

@rockxsj
Copy link
Copy Markdown
Contributor

@rockxsj rockxsj commented Jul 25, 2020

Tips

What is the purpose of the pull request

update .gitigonre to igonre some files
add presto datasource support

Brief change log

        new file:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/PrestoDataSource.java
        modified:   .gitignore
        modified:   dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
        modified:   dolphinscheduler-common/pom.xml
        modified:   dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
        modified:   dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/DbType.java
        modified:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/BaseDataSource.java
        modified:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/DataSourceFactory.java
        modified:   dolphinscheduler-ui/src/js/conf/home/pages/datasource/pages/list/_source/createDataSource.vue
        modified:   dolphinscheduler-ui/src/js/conf/home/store/dag/state.js
        modified:   dolphinscheduler-ui/src/js/conf/home/store/datasource/actions.js
        modified:   pom.xml

Verify this pull request

This pull request is already covered by existing tests.

rockxsj added 2 commits July 25, 2020 17:30
* add presto datasource support
084e1d1 
update .gitigonre to igonre some files
* use another presto driver
34b9042
@CalvinKirs
Copy link
Copy Markdown
Member

CalvinKirs commented Jul 26, 2020

Good job, adding a new jar requires sending an email to dev and getting approval from PPMC. At the same time, you can refer to the following article to check by yourself first.
https://github.com/apache/incubator-dolphinscheduler-website/blob/master/docs/zh-cn/development/DS-License.md

@rockxsj
Copy link
Copy Markdown
Contributor Author

rockxsj commented Jul 27, 2020

Good job, adding a new jar requires sending an email to dev and getting approval from PPMC. At the same time, you can refer to the following article to check by yourself first.
https://github.com/apache/incubator-dolphinscheduler-website/blob/master/docs/zh-cn/development/DS-License.md

done

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 27, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yangyichao-mango
Copy link
Copy Markdown
Contributor

yangyichao-mango commented Aug 4, 2020

Good job,
Please add test case to resolve the sonar 0.0% coverage.

@dengc367
Copy link
Copy Markdown
Contributor

dengc367 commented Aug 9, 2020

you need change the presto driver name com.facebook.presto.jdbc.PrestoDriver in presto driver configuration, not io.prestosql.jdbc.PrestoDriver when you use the facebook presto-jdbc jar , @rockxsj

@dengc367 dengc367 mentioned this pull request Aug 12, 2020
Merged
@dengc367
Copy link
Copy Markdown
Contributor

dengc367 commented Aug 12, 2020

I have modify some code from this presto feature and submit another pull request [Feature]modify some cases from rockxsj:Feature-presto to add presto datasource support
thanks @rockxsj for the codes.

@dengc367 dengc367 mentioned this pull request Aug 12, 2020
Closed
@davidzollo davidzollo added this to the 1.4.0 milestone Aug 14, 2020
davidzollo
davidzollo approved these changes Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job
I noticed that PR #3468 solved two bugs base on this PR，I will let him handle the potential conflict files and fix the bugs

@davidzollo davidzollo merged commit 2b46db0 into apache:dev Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rockxsj @CalvinKirs @yangyichao-mango @dengc367 @davidzollo