[Fix-3240][worker] Cannot find a (Map) Key deserializer for type#3245
Merged
lenboo merged 21 commits intoapache:devfrom Jul 21, 2020
Merged
[Fix-3240][worker] Cannot find a (Map) Key deserializer for type#3245lenboo merged 21 commits intoapache:devfrom
lenboo merged 21 commits intoapache:devfrom
Conversation
…e hive jdbc connection url ;
…ding the sonar 0.0% Coverage.
…duler into dev � Conflicts: � dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/HiveDataSource.java
- change the method of UdfFunc.toString use JsonString This closes apache#3245
- fix the junit test for full This closes apache#3245
- fix the sonarcloud merge error, Swap these 2 arguments so they are in the correct order: expected value, actual value. This closes apache#3245
| import com.fasterxml.jackson.databind.KeyDeserializer; | ||
| import java.io.IOException; | ||
|
|
||
| public class UdfFuncDeserializer extends KeyDeserializer { |
Contributor
There was a problem hiding this comment.
Hi,
Good job.
Because UdfFuncDeserializer is not used by a entity class, and just for UdfFunc KeyDeserializer, is it better to move this file as a static class in UdfFunc.java?
Contributor
Author
There was a problem hiding this comment.
en . I have moved this file as a static class in UdfFunc.java.
Contributor
|
Hi, Very good work. Thx a lot for your contribution. |
Contributor
Author
|
Yes,it would be better.i will fix it later today
…---Original---
From: "Yichao Yang"<notifications@github.com>
Date: Mon, Jul 20, 2020 09:34 AM
To: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
Cc: "LEI SHENG"<534634799@qq.com>;"Author"<author@noreply.github.com>;
Subject: Re: [apache/incubator-dolphinscheduler] [Fix-3240][worker] Cannot find a (Map) Key deserializer for type (#3245)
@yangyichao-mango commented on this pull request.
In dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/UdfFuncDeserializer.java:
> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.dao.entity; + +import org.apache.dolphinscheduler.common.utils.JSONUtils; +import org.apache.dolphinscheduler.common.utils.StringUtils; +import com.fasterxml.jackson.databind.DeserializationContext; +import com.fasterxml.jackson.databind.KeyDeserializer; +import java.io.IOException; + +public class UdfFuncDeserializer extends KeyDeserializer {
Hi,
Good job.
Because UdfFuncDeserializer is not used by a entity class, and just for UdfFunc KeyDeserializer, is it better to move this file as a static class in UdfFunc.java or JSONUtils.java?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
move the class UdfFuncDeserializer.java to UdfFunc.java This closes apache#3245
add blank line This closes apache#3245
add the unit test of UdfFunc.java This closes apache#3245
remove the UdfFuncTest.java from maven-surefire-plugin list This closes apache#3245
add the UdfFuncTest to the root pom maven-surefire-plugin This closes apache#3245
|
Kudos, SonarCloud Quality Gate passed!
|
yangyichao-mango
approved these changes
Jul 21, 2020
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
fix the bug #3240 [Bug][worker] Cannot find a (Map) Key deserializer for type #3240
Brief change log
Verify this pull request
This change added tests and can be verified as follows: