dag add close buttion#3195
Merged
khadgarmage merged 34 commits intoapache:devfrom Jul 15, 2020
BoYiZhang:dev
Merged
Conversation
update code
dag add close buttion
Contributor
|
@break60 please review , thx |
Contributor
|
Re-update |
update code
Contributor
Author
|
e2e test error . Please contact the person concerned for repair thx |
Contributor
|
Since the close button is added to the dag page, the xpath path of the save button changes. You need to change the xpath path of CLICK_SAVE_WORKFLOW_BUTTON of org.apache.dolphinscheduler.locator.project.CreateWorkflowLocator |
modify submit workflow button
modify CLICK_ADD_BUTTON
delete print
in addition update '- XX: largepagesizeinbytes = 128M' to '- XX: largepagesizeinbytes = 10M'
Contributor
|
SonarCloud Code Analysis is not running . please retry commit. Thx |
Contributor
Author
It has been re submitted twice, but sonarcloud code analysis is not running |
Contributor
|
+1 |
|
Kudos, SonarCloud Quality Gate passed!
|
tswstarplanet
pushed a commit
to tswstarplanet/incubator-dolphinscheduler
that referenced
this pull request
Jul 15, 2020
* fix bug Delete invalid field: executorcores Modify verification prompt * fix bug Delete invalid field: executorcores Modify verification prompt * fix bug Delete invalid field: executorcores Modify verification prompt * dag add close button * reset last version * reset last version * dag add close buttion dag add close buttion * update CLICK_SAVE_WORKFLOW_BUTTON xpath * updae CLICK_SAVE_WORKFLOW_BUTTON xpath * updae CLICK_SAVE_WORKFLOW_BUTTON xpath * updae CLICK_SAVE_WORKFLOW_BUTTON xpath * Update CreateWorkflowLocator.java modify submit workflow button * Update CreateWorkflowLocator.java * Update CreateWorkflowLocator.java modify CLICK_ADD_BUTTON * Update CreateWorkflowLocator.java delete print * Update CreateWorkflowLocator.java 1 * Update CreateWorkflowLocator.java 1 * Setting '-XX:+DisableExplicitGC ' causes netty memory leaks in addition update '- XX: largepagesizeinbytes = 128M' to '- XX: largepagesizeinbytes = 10M' * Update dag.vue * Update dag.vue * Update dag.vue * Update CreateWorkflowLocator.java * Revert "Setting '-XX:+DisableExplicitGC ' causes netty memory leaks" This reverts commit 3a2cba7 Co-authored-by: dailidong <dailidong66@gmail.com> Co-authored-by: xingchun-chen <55787491+xingchun-chen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dag add close buttion
#3190