[PROPOSAL-3139] Datasource selection changes from radio to select#3142
Merged
qiaozhanwei merged 9 commits intoapache:devfrom Jul 13, 2020
wuchunfu:dev
Merged
[PROPOSAL-3139] Datasource selection changes from radio to select#3142qiaozhanwei merged 9 commits intoapache:devfrom wuchunfu:dev
qiaozhanwei merged 9 commits intoapache:devfrom
wuchunfu:dev
Conversation
| mounted () { | ||
| }, | ||
| components: { mPopup, mListBoxF } | ||
| components: { mPopup, mListBoxF, mSelectInput } |
Contributor
There was a problem hiding this comment.
Hi,
What is the purpose of introducing mSelectInput component?
If you want to add drop-down filtering options, Ans-UI native is supported.
Member
Author
There was a problem hiding this comment.
Sorry, this is my question. Thank you very much for your code review.
Contributor
|
Thx a lot for your contribution, LGTM. |
yangyichao-mango
approved these changes
Jul 6, 2020
Contributor
Contributor
|
I think the difference between changing and changing is not very big. Selecting the radio button allows users to easily understand more data, but there are too many values here, beyond the scope of the page display, you can also change to select |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Datasource selection changes from radio to select. #3139
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.