Skip to content

[bugFix#3085]fix dag zoom#3103

Merged
lenboo merged 4 commits intoapache:devfrom
satcblue:BUG#3085
Jul 2, 2020
Merged

[bugFix#3085]fix dag zoom#3103
lenboo merged 4 commits intoapache:devfrom
satcblue:BUG#3085

Conversation

@satcblue
Copy link
Copy Markdown
Contributor

@satcblue satcblue commented Jun 30, 2020 •
edited
Loading

What is the purpose of the pull request

FIX BUG #3085

Brief change log

jsPlumbHandle.js
dragZoom.js
util.js

Attention:

It is important to note that dragging the canvas is not supported now! Despite this feature before, it didn't actually do much. About dragging the canvas, you can consider other ways to implement under this modification (it can play the effect of pulling the scroll bar)

@satcblue satcblue changed the title fix dag zoom [bugFix#3085]fix dag zoom Jun 30, 2020
@satcblue
Copy link
Copy Markdown
Contributor Author

satcblue commented Jun 30, 2020

According to #3085 , i think the method of using jsplumb is not feasible. jsplumb toolkit version is a commercial version(LOL).
I once implemented the function of dragging and dropping canvas, but its performance is not satisfactory. I will be very grateful If u can give me some suggestions.

@davidzollo davidzollo linked an issue Jul 1, 2020 that may be closed by this pull request
[BUG] after zoom or drag the dag view, cant plcae node correctly and may be disappear #3085
Closed
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Jul 1, 2020

@break60 please review this PR

@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Jul 1, 2020

good job,thanks for your first contribution.
if you need help, please send mail to dev@dolphinscheduler.apache.org or my wechat(510570367), when added, please tell me your github id, thx

break60
break60 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@break60 break60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

lenboo
lenboo approved these changes Jul 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #3103 into dev will decrease coverage by 6.21%.
The diff coverage is 24.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3103      +/-   ##
============================================
- Coverage     39.60%   33.39%   -6.22%     
+ Complexity     2717     2372     -345     
============================================
  Files           436      441       +5     
  Lines         20111    20518     +407     
  Branches       2451     2505      +54     
============================================
- Hits           7965     6851    -1114     
- Misses        11391    13020    +1629     
+ Partials        755      647     -108
Impacted Files Coverage Δ Complexity Δ
...apache/dolphinscheduler/alert/utils/Constants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...scheduler/api/controller/DataSourceController.java 3.63% <0.00%> (ø) 2.00 <0.00> (ø)
...olphinscheduler/api/service/DataSourceService.java 0.61% <0.00%> (-6.67%) 2.00 <0.00> (-3.00)
...nscheduler/api/service/ProcessInstanceService.java 76.40% <0.00%> (ø) 33.00 <0.00> (ø)
.../apache/dolphinscheduler/api/utils/CheckUtils.java 61.53% <ø> (ø) 19.00 <0.00> (ø)
...dolphinscheduler/common/enums/ExecutionStatus.java 60.00% <0.00%> (-1.77%) 3.00 <0.00> (ø)
...apache/dolphinscheduler/common/model/TaskNode.java 37.34% <0.00%> (-1.41%) 15.00 <0.00> (ø)
...inscheduler/common/task/datax/DataxParameters.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...pache/dolphinscheduler/common/utils/DateUtils.java 87.50% <ø> (+0.40%) 26.00 <0.00> (+1.00)
...che/dolphinscheduler/common/utils/HadoopUtils.java 33.99% <0.00%> (+0.49%) 21.00 <0.00> (ø)
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a7bb4...aca923d. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lenboo lenboo merged commit 631cc6e into apache:dev Jul 2, 2020
lenboo added a commit that referenced this pull request Jul 2, 2020
@satcblue @davidzollo @lenboo
fix dag zoom (#3103)
78c7dc1 
Co-authored-by: linhaojie <linhaojie@lizhi.fm>
Co-authored-by: dailidong <dailidong66@gmail.com>
Co-authored-by: bao liang <29528966+lenboo@users.noreply.github.com>
@lenboo lenboo added this to the 1.3.1-release milestone Jul 2, 2020
@satcblue
Copy link
Copy Markdown
Contributor Author

satcblue commented Jul 2, 2020

good job,thanks for your first contribution.
if you need help, please send mail to dev@dolphinscheduler.apache.org or my wechat(510570367), when added, please tell me your github id, thx

THX! I am very happy to contribute to open source software. Thank you for leaving your contact information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenboo lenboo lenboo approved these changes

+1 more reviewer

@break60 break60 break60 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.1-release

Development

Successfully merging this pull request may close these issues.

[BUG] after zoom or drag the dag view, cant plcae node correctly and may be disappear

5 participants

@satcblue @davidzollo @codecov-commenter @break60 @lenboo