Skip to content

Using Jackson instead of Fastjson#2960

Merged
gabry-lab merged 41 commits intoapache:devfrom
simon824:dev
Jun 13, 2020
Merged

Using Jackson instead of Fastjson#2960
gabry-lab merged 41 commits intoapache:devfrom
simon824:dev

Conversation

@simon824
Copy link
Copy Markdown
Member

snapshot of #2872
Resolved the conflict

simon824 and others added 30 commits June 2, 2020 15:54
2. remove getMapper method,replace with toList()
3. rewrite toList method,support constructCollectionType.
4. parseObject(resp, Map.class) replace to toMap() method
5. rename JacksonSerialize to JsonSerializer

rewrite createArrayNode,createObjectNode method will Affect too many lines ,i will fix it in the next pr.
2. remove getMapper method,replace with toList()
3. rewrite toList method,support constructCollectionType.
4. parseObject(resp, Map.class) replace to toMap() method
5. rename JacksonSerialize to JsonSerializer

rewrite createArrayNode,createObjectNode method will Affect too many lines ,i will fix it in the next pr.
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2960 into dev will increase coverage by 0.59%.
The diff coverage is 46.98%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2960      +/-   ##
============================================
+ Coverage     38.56%   39.15%   +0.59%     
- Complexity     2658     2678      +20     
============================================
  Files           436      435       -1     
  Lines         20090    20116      +26     
  Branches       2444     2453       +9     
============================================
+ Hits           7747     7876     +129     
+ Misses        11624    11503     -121     
- Partials        719      737      +18     
Impacted Files Coverage Δ Complexity Δ
...pache/dolphinscheduler/alert/utils/ExcelUtils.java 78.94% <ø> (ø) 8.00 <0.00> (ø)
...apache/dolphinscheduler/api/dto/ScheduleParam.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rg/apache/dolphinscheduler/api/dto/gantt/Task.java 62.96% <ø> (ø) 9.00 <0.00> (ø)
...scheduler/api/dto/resources/ResourceComponent.java 72.72% <ø> (ø) 21.00 <0.00> (ø)
...he/dolphinscheduler/api/dto/treeview/Instance.java 39.13% <ø> (ø) 3.00 <0.00> (ø)
...e/dolphinscheduler/api/service/BaseDAGService.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...olphinscheduler/api/service/DataSourceService.java 2.22% <0.00%> (ø) 3.00 <0.00> (ø)
...cheduler/api/service/ProcessDefinitionService.java 60.86% <0.00%> (ø) 75.00 <0.00> (ø)
...dolphinscheduler/api/service/SchedulerService.java 2.52% <ø> (ø) 3.00 <0.00> (ø)
.../apache/dolphinscheduler/api/utils/CheckUtils.java 61.53% <ø> (ø) 19.00 <0.00> (ø)
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56ae9e...3eb3670. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

34.6% 34.6% Coverage
0.7% 0.7% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants