Skip to content

Using Jackson instead of Fastjson#2872

Merged
gabry-lab merged 35 commits intoapache:devfrom
simon824:jackson
Jun 13, 2020
Merged

Using Jackson instead of Fastjson#2872
gabry-lab merged 35 commits intoapache:devfrom
simon824:jackson

Conversation

@simon824
Copy link
Copy Markdown
Member

@simon824 simon824 commented Jun 2, 2020

replace all fastjson

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 2, 2020 •
edited
Loading

Codecov Report

Merging #2872 into dev will increase coverage by 0.64%.
The diff coverage is 46.98%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2872      +/-   ##
============================================
+ Coverage     38.14%   38.78%   +0.64%     
- Complexity     2620     2648      +28     
============================================
  Files           436      435       -1     
  Lines         20079    20105      +26     
  Branches       2443     2452       +9     
============================================
+ Hits           7659     7798     +139     
+ Misses        11711    11581     -130     
- Partials        709      726      +17
Impacted Files Coverage Δ Complexity Δ
...pache/dolphinscheduler/alert/utils/ExcelUtils.java 78.94% <ø> (ø) 8.00 <0.00> (ø)
...apache/dolphinscheduler/api/dto/ScheduleParam.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rg/apache/dolphinscheduler/api/dto/gantt/Task.java 62.96% <ø> (ø) 9.00 <0.00> (ø)
...scheduler/api/dto/resources/ResourceComponent.java 72.72% <ø> (ø) 21.00 <0.00> (ø)
...he/dolphinscheduler/api/dto/treeview/Instance.java 39.13% <ø> (ø) 3.00 <0.00> (ø)
...e/dolphinscheduler/api/service/BaseDAGService.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...olphinscheduler/api/service/DataSourceService.java 2.22% <0.00%> (ø) 3.00 <0.00> (ø)
...cheduler/api/service/ProcessDefinitionService.java 60.86% <0.00%> (ø) 75.00 <0.00> (ø)
...dolphinscheduler/api/service/SchedulerService.java 2.52% <ø> (ø) 3.00 <0.00> (ø)
.../apache/dolphinscheduler/api/utils/CheckUtils.java 61.53% <ø> (ø) 19.00 <0.00> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d0379...1b7d8ee. Read the comment docs.

@clay4megtr
Copy link
Copy Markdown
Contributor

clay4megtr commented Jun 3, 2020

hi simon, maybe we can split this pr into some small pr ?
by the way, the number of files modified by a single pr should not exceed 10

@simon824
Copy link
Copy Markdown
Member Author

simon824 commented Jun 4, 2020

hi simon, maybe we can split this pr into some small pr ?
by the way, the number of files modified by a single pr should not exceed 10

This pr is special, most of the modification is only a jsonutils method. It has been discussed in the community and recommended to complete all once.

@wen-hemin
Copy link
Copy Markdown
Contributor

wen-hemin commented Jun 5, 2020

For date type, Jackson does not support "yyyy-MM-dd HH:mm:ss" format by default.
Date format needs to be specified.

gabry-lab
gabry-lab suggested changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give some suggestion & review left code

gabry-lab
gabry-lab suggested changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review some files

gabry-lab
gabry-lab suggested changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some changes to be done

gabry-lab
gabry-lab approved these changes Jun 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gabry-lab
Copy link
Copy Markdown
Member

gabry-lab commented Jun 12, 2020

@simon824 Do you mind to fix the bad code smell before merging this PR.
I think this is the final task to do

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

34.6% 34.6% Coverage
0.7% 0.7% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

gabry-lab
gabry-lab approved these changes Jun 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gabry-lab gabry-lab self-assigned this Jun 12, 2020
@gabry-lab
Copy link
Copy Markdown
Member

gabry-lab commented Jun 12, 2020

@simon824 new conflict file, please fix this ,once it done, I will merge this PR to dev branch

@simon824 simon824 mentioned this pull request Jun 13, 2020
Merged
@gabry-lab gabry-lab merged commit 1b7d8ee into apache:dev Jun 13, 2020
@gabry-lab
Copy link
Copy Markdown
Member

gabry-lab commented Jun 13, 2020

#2960 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gabry-lab gabry-lab gabry-lab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gabry-lab gabry-lab

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@simon824 @codecov-commenter @clay4megtr @wen-hemin @gabry-lab