Skip to content

[Hotfix-2922][common] Fix Jackson UDde error (#2922)#2926

Merged
davidzollo merged 2 commits intoapache:devfrom
yangyichao-mango:hotfix-2922
Jun 17, 2020
Merged

[Hotfix-2922][common] Fix Jackson UDde error (#2922)#2926
davidzollo merged 2 commits intoapache:devfrom
yangyichao-mango:hotfix-2922

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango commented Jun 8, 2020

What is the purpose of the pull request

Fix Jackson user defined deserializer error

Brief change log

  • Change org.apache.dolphinscheduler.common.utils.JSONUtils.JsonDataDeserializer#deserialize() function implement
  • Delete the use of fastjson in org.apache.dolphinscheduler.common.utils.JSONUtilsTest

Verify this pull request

This change added tests and can be verified as follows:

  • Added org.apache.dolphinscheduler.common.utils.JSONUtilsTest#jsonDataDeserializerTest() to verify the change.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 8, 2020 •
edited
Loading

Codecov Report

Merging #2926 into dev will increase coverage by 0.35%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2926      +/-   ##
============================================
+ Coverage     39.11%   39.47%   +0.35%     
- Complexity     2678     2699      +21     
============================================
  Files           435      435              
  Lines         20119    20121       +2     
  Branches       2454     2455       +1     
============================================
+ Hits           7870     7942      +72     
+ Misses        11514    11434      -80     
- Partials        735      745      +10
Impacted Files Coverage Δ Complexity Δ
...pache/dolphinscheduler/common/utils/JSONUtils.java 71.21% <33.33%> (+2.46%) 18.00 <0.00> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø) 25.00% <0.00%> (ø%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.42% <0.00%> (+3.17%) 14.00% <0.00%> (+1.00%)
...ver/master/consumer/TaskPriorityQueueConsumer.java 51.82% <0.00%> (+13.13%) 16.00% <0.00%> (ø%)
...duler/server/entity/DataxTaskExecutionContext.java 95.00% <0.00%> (+20.00%) 13.00% <0.00%> (+2.00%)
...apache/dolphinscheduler/common/model/TaskNode.java 38.75% <0.00%> (+38.75%) 15.00% <0.00%> (+15.00%)
...apache/dolphinscheduler/common/enums/Priority.java 83.33% <0.00%> (+83.33%) 2.00% <0.00%> (+2.00%)
...he/dolphinscheduler/common/enums/SqoopJobType.java 88.88% <0.00%> (+88.88%) 3.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7fd72...78328dd. Read the comment docs.

@gabry-lab
Copy link
Copy Markdown
Member

gabry-lab commented Jun 13, 2020

#2960 has been merged ,so you can resolve the conflicting files , or close this issue

@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Jun 14, 2020

#2960 has been merged ,so you can resolve the conflicting files , or close this issue

@gabrywu Thx for your review. I've rebased the branch and this UDde error still exists in newest dev branch, and I fix it. Can you help to review this PR? Thx a lot.

@davidzollo davidzollo linked an issue Jun 17, 2020 that may be closed by this pull request
[BUG] Jackson UDSerde error #2922
Closed
davidzollo
davidzollo approved these changes Jun 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@davidzollo davidzollo merged commit 0744d40 into apache:dev Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Jackson UDSerde error

4 participants

@yangyichao-mango @codecov-commenter @gabry-lab @davidzollo