Skip to content

[Feature-2127][sql-schema] Fix the mysql version limited error (#2127)#2914

Closed
yangyichao-mango wants to merge 1 commit intoapache:dev-1.1.0from
yangyichao-mango:feature-dev-1.1.0-2127
Closed

[Feature-2127][sql-schema] Fix the mysql version limited error (#2127)#2914
yangyichao-mango wants to merge 1 commit intoapache:dev-1.1.0from
yangyichao-mango:feature-dev-1.1.0-2127

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango commented Jun 6, 2020 •
edited
Loading

What is the purpose of the pull request

Fix the mysql version and datetime sql syntax limited error for 5.5x - 5.64.

Brief change log

  • Remove the CURRENT_TIMESTAMP in sql file.
  • Change the sql datetime(0) syntax to common syntax datetime, because mysql5.5x does not support the datetime(0) syntax, and datetime syntax is be in common use in mysql5.x and mysql8.x.
  • Add the setter for create_time and update_time in ProjectMapperProvider.java

Verify this pull request

This pull request is code cleanup without any test coverage.

@gabry-lab gabry-lab mentioned this pull request Jun 13, 2020
Merged
@gabry-lab gabry-lab closed this Jun 13, 2020
@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Jun 23, 2020

Hi @gabrywu , can you help to reopen this PR, this PR is aim to fix the 1.1.0 version mysql 5.5.x error, and it is not the repeated fix of #2915 (fix for 1.3.0) #2911 (fix for dev branch).
Thx a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yangyichao-mango @gabry-lab