Skip to content

[Feature-2127][sql-schema] Fix the mysql version limited error (#2127)#2911

Merged
davidzollo merged 3 commits intoapache:devfrom
yangyichao-mango:feature-2127
Jun 15, 2020
Merged

[Feature-2127][sql-schema] Fix the mysql version limited error (#2127)#2911
davidzollo merged 3 commits intoapache:devfrom
yangyichao-mango:feature-2127

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango commented Jun 6, 2020

What is the purpose of the pull request

Fix the mysql version and datetime sql syntax limited error for 5.5x - 5.64.

Brief change log

  • Remove the CURRENT_TIMESTAMP in sql file.
  • Change the sql datetime(0) syntax to common syntax datetime, because mysql5.5x does not support the datetime(0) syntax, and datetime syntax is be in common use in mysql5.x and mysql8.x.
  • There is no need to set datetime in java code, because the default time was set up before.

Verify this pull request

This pull request is code cleanup without any test coverage.

@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Jun 6, 2020

good idea.

if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine

@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Jun 6, 2020 •
edited
Loading

good idea.

if remove default time set in sql file, but create_time and update_time is not set in java code in 1.0 version(you can check the code, I'm not remember clearly), system will not work fine

Thx for your review.

I've checked all the active dev branches and fixed 2127 in those dev branches

@yangyichao-mango yangyichao-mango changed the title [Feature-2127][sql-schema] Fix the mysql version limited error [Feature-2127][sql-schema] Fix the mysql version limited error (#2127) Jun 9, 2020
@gabry-lab gabry-lab mentioned this pull request Jun 13, 2020
Merged
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #2911 into dev will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2911      +/-   ##
============================================
- Coverage     39.57%   39.39%   -0.18%     
+ Complexity     2711     2701      -10     
============================================
  Files           435      435              
  Lines         20116    20116              
  Branches       2453     2453              
============================================
- Hits           7960     7925      -35     
- Misses        11400    11438      +38     
+ Partials        756      753       -3
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
.../server/worker/processor/TaskExecuteProcessor.java 10.16% <0.00%> (-27.12%) 1.00% <0.00%> (-2.00%)
...nscheduler/server/entity/TaskExecutionContext.java 89.10% <0.00%> (-9.91%) 61.00% <0.00%> (-5.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) 25.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c7f76...39528e9. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

davidzollo
davidzollo approved these changes Jun 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Jun 15, 2020

good job, please contact me(lidongdai@apache.org) or wechat(510570367) , when added, please tell me your github id, thx

@davidzollo davidzollo merged commit f7ea4f1 into apache:dev Jun 15, 2020
@davidzollo davidzollo added the enhancement New feature or request label Jun 15, 2020
@yangyichao-mango yangyichao-mango mentioned this pull request Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yangyichao-mango @davidzollo @codecov-commenter