simply NettyExecutorManager.execute logic making it readable#2744
Merged
davidzollo merged 4 commits intoapache:devfrom May 19, 2020
Merged
simply NettyExecutorManager.execute logic making it readable#2744davidzollo merged 4 commits intoapache:devfrom
davidzollo merged 4 commits intoapache:devfrom
Conversation
Member
Author
|
hi, @qiaozhanwei could you help to review this PR ? |
Codecov Report
@@ Coverage Diff @@
## dev #2744 +/- ##
============================================
- Coverage 37.19% 37.00% -0.19%
+ Complexity 2554 2543 -11
============================================
Files 434 434
Lines 19977 19975 -2
Branches 2423 2424 +1
============================================
- Hits 7430 7392 -38
- Misses 11880 11916 +36
Partials 667 667
Continue to review full report at Codecov.
|
qiaozhanwei
reviewed
May 19, 2020
Contributor
There was a problem hiding this comment.
great，code is simplify，but poor readability， @other reivew ，I personally think it is necessary to retry in the catch
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
+1 |
nauu
pushed a commit
to nauu/incubator-dolphinscheduler
that referenced
this pull request
May 19, 2020
…2744) * simply NettyExecutorManager.execute logic making it readable * fix NPE * remove unused import Co-authored-by: dailidong <dailidong66@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Brief change log