Skip to content

add retryCallSilent to RetryerUtils making it easy to use#2729

Merged
qiaozhanwei merged 2 commits intoapache:devfrom
gabry-lab:retryCallSilent
May 19, 2020
Merged

add retryCallSilent to RetryerUtils making it easy to use#2729
qiaozhanwei merged 2 commits intoapache:devfrom
gabry-lab:retryCallSilent

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 17, 2020

Codecov Report

Merging #2729 into dev will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2729      +/-   ##
============================================
- Coverage     37.17%   37.09%   -0.09%     
+ Complexity     2553     2548       -5     
============================================
  Files           434      434              
  Lines         19977    19985       +8     
  Branches       2423     2423              
============================================
- Hits           7427     7413      -14     
- Misses        11882    11903      +21     
- Partials        668      669       +1     
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/common/utils/RetryerUtils.java 100.00% <100.00%> (ø) 11.00 <3.00> (+3.00)
...duler/server/entity/DataxTaskExecutionContext.java 35.00% <0.00%> (-60.00%) 7.00% <0.00%> (-6.00%)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...ver/master/consumer/TaskPriorityQueueConsumer.java 54.41% <0.00%> (-4.42%) 16.00% <0.00%> (ø%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-3.18%) 13.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1771aa5...cb0b7ee. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 772a8e2 into apache:dev May 19, 2020
@gabry-lab gabry-lab deleted the retryCallSilent branch May 19, 2020 03:40
nauu pushed a commit to nauu/incubator-dolphinscheduler that referenced this pull request May 19, 2020
* add retryCallSilent to RetryerUtils making it easy to use

* add more detail to java doc of retryCallSilent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants