add RetryerUtils to retry async & sync function gracefully#2697
Merged
qiaozhanwei merged 6 commits intoapache:devfrom May 14, 2020
Merged
add RetryerUtils to retry async & sync function gracefully#2697qiaozhanwei merged 6 commits intoapache:devfrom
qiaozhanwei merged 6 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2697 +/- ##
============================================
- Coverage 37.12% 37.08% -0.05%
- Complexity 2545 2546 +1
============================================
Files 433 434 +1
Lines 19958 19975 +17
Branches 2423 2423
============================================
- Hits 7409 7407 -2
- Misses 11881 11900 +19
Partials 668 668
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Now, dolphin already refactor worker ,and netty is being used.
It can be predicted that async method will be more and more used ,and function retryer is necessary .
If we simply call function twice or more , it's ugly and beyonds understanding
So I suggest we introduce a RetryerUtils class
Brief change log