add Retryer to retry Task Execute ack gracefully#2679
add Retryer to retry Task Execute ack gracefully#2679gabry-lab wants to merge 3 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2679 +/- ##
============================================
- Coverage 36.32% 36.20% -0.12%
+ Complexity 2481 2475 -6
============================================
Files 431 431
Lines 19893 19900 +7
Branches 2421 2421
============================================
- Hits 7226 7205 -21
- Misses 12025 12052 +27
- Partials 642 643 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
qiaozhanwei
left a comment
There was a problem hiding this comment.
I think it is best to encapsulate a tool class, because it needs to be called in many places, not only in ack and response
for example master send task to worker，and worker fetch ip from zookeeper etc，all need this tool
great, I will close this PR, and create another which encapsulate a tool class to make it reused easier |
Tips
What is the purpose of the pull request
Now, dolphin already refactor worker ,and netty is being used.
It can be predicted that async method will be more and more used ,and function retryer is necessary .
If we simply call function twice or more , it's ugly and beyonds understanding
So I suggest we introduce a retryer class ,for example https://github.com/rholder/guava-retrying
Brief change log