Skip to content

Adapting partial code(file name start with O) to the sonar cloud rule#2259

Merged
davidzollo merged 4 commits intoapache:devfrom
gabry-lab:fixSonarOx
Mar 31, 2020
Merged

Adapting partial code(file name start with O) to the sonar cloud rule#2259
davidzollo merged 4 commits intoapache:devfrom
gabry-lab:fixSonarOx

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 21, 2020

Codecov Report

Merging #2259 into dev will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #2259   +/-   ##
=========================================
  Coverage     31.27%   31.28%           
  Complexity     1768     1768           
=========================================
  Files           343      343           
  Lines         18103    18099    -4     
  Branches       2269     2268    -1     
=========================================
  Hits           5662     5662           
+ Misses        11849    11845    -4     
  Partials        592      592           
Impacted Files Coverage Δ Complexity Δ
.../apache/dolphinscheduler/common/utils/OSUtils.java 48.63% <100.00%> (+0.63%) 23.00 <0.00> (ø)
...he/dolphinscheduler/api/service/LoggerService.java 91.30% <0.00%> (-8.70%) 7.00% <0.00%> (-1.00%)
.../apache/dolphinscheduler/common/utils/IOUtils.java 50.00% <0.00%> (+50.00%) 1.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b17435...146fbac. Read the comment docs.

@davidzollo
Copy link
Copy Markdown
Contributor

Please solve Conflicting files locally, thx

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@davidzollo davidzollo merged commit 718e4b1 into apache:dev Mar 31, 2020
@gabry-lab gabry-lab deleted the fixSonarOx branch April 3, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants