Skip to content

Adapting partial code(file name start with O) to the sonar cloud rule#2185

Closed
gabry-lab wants to merge 1 commit intoapache:devfrom
gabry-lab:fixSonarO
Closed

Adapting partial code(file name start with O) to the sonar cloud rule#2185
gabry-lab wants to merge 1 commit intoapache:devfrom
gabry-lab:fixSonarO

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab commented Mar 15, 2020

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 15, 2020

Codecov Report

Merging #2185 into dev will increase coverage by 29.87%.
The diff coverage is 43.56%.

Impacted file tree graph

@@             Coverage Diff              @@
##               dev    #2185       +/-   ##
============================================
+ Coverage     0.00%   29.87%   +29.87%     
- Complexity       0     1632     +1632     
============================================
  Files          388      336       -52     
  Lines        20542    17800     -2742     
  Branches      3269     2239     -1030     
============================================
+ Hits             0     5317     +5317     
+ Misses       20542    11920     -8622     
- Partials         0      563      +563
Impacted Files Coverage Δ Complexity Δ
...org/apache/dolphinscheduler/alert/AlertServer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...heduler/alert/manager/EnterpriseWeChatManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...che/dolphinscheduler/alert/runner/AlertSender.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...dolphinscheduler/alert/template/AlertTemplate.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...duler/alert/template/impl/DefaultHTMLTemplate.java 77.55% <ø> (+77.55%) 12.00 <0.00> (+12.00)
...apache/dolphinscheduler/alert/utils/Constants.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...inscheduler/alert/utils/EnterpriseWeChatUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...apache/dolphinscheduler/alert/utils/FuncUtils.java 91.66% <ø> (+91.66%) 5.00 <0.00> (+5.00)
...apache/dolphinscheduler/alert/utils/MailUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...olphinscheduler/api/controller/BaseController.java 5.00% <0.00%> (+5.00%) 2.00 <0.00> (+2.00)
... and 531 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ebbf2...42bcae8. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
25.0% 25.0% Duplication

@xingchun-chen
Copy link
Copy Markdown
Contributor

xingchun-chen commented Mar 17, 2020

Please re-merge the code and submit

@gabry-lab
Copy link
Copy Markdown
Member Author

gabry-lab commented Mar 19, 2020

Please re-merge the code and submit

done

@xingchun-chen
Copy link
Copy Markdown
Contributor

xingchun-chen commented Mar 19, 2020

Are you sure to rebase the dev code and push it again? there is only one commit in pr

@gabry-lab
Copy link
Copy Markdown
Member Author

gabry-lab commented Mar 19, 2020

Are you sure to rebase the dev code and push it again? there is only one commit in pr

Yes.

@xingchun-chen
Copy link
Copy Markdown
Contributor

xingchun-chen commented Mar 20, 2020

e2e running code is not up to date, can you try to close this pr and push again?

@gabry-lab gabry-lab closed this Mar 21, 2020
@gabry-lab gabry-lab deleted the fixSonarO branch March 21, 2020 10:15
@gabry-lab gabry-lab mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabry-lab @codecov-io @xingchun-chen