Skip to content

Fix bug #1986.#1987

Merged
Eights-Li merged 1 commit intoapache:devfrom
nauu:bug/#1986
Feb 25, 2020
Merged

Fix bug #1986.#1987
Eights-Li merged 1 commit intoapache:devfrom
nauu:bug/#1986

Conversation

@nauu
Copy link
Copy Markdown
Contributor

@nauu nauu commented Feb 21, 2020

What is the purpose of the pull request

Fix bug #1986

When in the projects define page, click the toolbar's button(task type) will cause the task details window switch to new one.

For now, the task details window will not switch.

Brief change log

  • Edit jsPlumbHandle.js
  • Edit dag.vue

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

When in the projects define page, click the toolbar's button(task type) will cause the task details window switch to new one.

For now, the task details window will not switch.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 21, 2020

Codecov Report

Merging #1987 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #1987   +/-   ##
=========================================
  Coverage     30.84%   30.84%           
  Complexity     1382     1382           
=========================================
  Files           294      294           
  Lines         15022    15022           
  Branches       1810     1810           
=========================================
  Hits           4633     4633           
+ Misses         9930     9929    -1     
- Partials        459      460    +1
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.18% <0%> (-3.39%) 12% <0%> (-1%)
...he/dolphinscheduler/api/service/LoggerService.java 100% <0%> (+8.69%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e0a66...f59bae5. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@break60
Copy link
Copy Markdown
Contributor

break60 commented Feb 24, 2020

+1

Copy link
Copy Markdown
Contributor

@Eights-Li Eights-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Eights-Li Eights-Li merged commit 5f3d88e into apache:dev Feb 25, 2020
elonlo pushed a commit to fordeal-smalldata/incubator-dolphinscheduler that referenced this pull request Jul 26, 2021
When in the projects define page, click the toolbar's button(task type) will cause the task details window switch to new one.

For now, the task details window will not switch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants