Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1978 +/- ##
============================================
+ Coverage 30.28% 30.82% +0.53%
- Complexity 1367 1381 +14
============================================
Files 294 294
Lines 14999 15022 +23
Branches 1806 1810 +4
============================================
+ Hits 4543 4631 +88
+ Misses 10006 9931 -75
- Partials 450 460 +10
Continue to review full report at Codecov.
|
| @@ -1,136 +1,74 @@ | |||
| # | |||
There was a problem hiding this comment.
Why delete license announcement?
There was a problem hiding this comment.
I have forgot it, because this dockerfile is new.
dockerfile/Dockerfile
Outdated
| ARG version | ||
| ARG tar_version | ||
| #1. using aliyun mirror, and install dos2unix shadow bash openrc python sudo vim wget iputils net-tools ssh pip kazoo | ||
| RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" /etc/apk/repositories && \ |
There was a problem hiding this comment.
Can Alibaba Cloud Mirror make download quickly abroad?
| chmod +x /opt/dolphinscheduler/script/*.sh && \ | ||
| chmod +x /opt/dolphinscheduler/bin/*.sh && \ | ||
| chmod +x /opt/zookeeper/bin/*.sh && \ | ||
| dos2unix /root/startup-init-conf.sh && \ |
There was a problem hiding this comment.
Because bash script with Windows line-ending CRLF won't work on Linux.
UNIX and UNIX-like operating systems (including Mac OS X) represent line endings as LF alone.
Converting line-ending using dos2unix.
| mvn clean compile package -Prelease | ||
|
|
||
| # mv dolphinscheduler-bin.tar.gz file to dockerfile directory | ||
| echo -e "mv $(pwd)/dolphinscheduler-dist/target/apache-dolphinscheduler-incubating-${VERSION}-SNAPSHOT-dolphinscheduler-bin.tar.gz $(pwd)/dockerfile/\n" |
There was a problem hiding this comment.
It is better to build image based on the current branch code, both CI and release can be used, rather than build based on the package
There was a problem hiding this comment.
User can use it, and CI can also use it.
|
find some conflicting files |
…duler into dev # Conflicts: # dockerfile/conf/dolphinscheduler/conf/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml # dockerfile/conf/dolphinscheduler/conf/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.xml
|
Kudos, SonarCloud Quality Gate passed!
|
* Support DS to create user and group in windows environment * Add unit test * delete combined-server config in dolphinscheduler-daemon.sh file * refactor dockerfile * modify dockerfile * modify dockerfile
Refactor dockerfile, and its size is about 600MB.
Please read
README.md.