Merged
Conversation
When create a new task or edit an exist task.The task details window will be open. Then if delete the task node or click the DataSource menu. And the task details window still open. The task details window should be close.
Codecov Report
@@ Coverage Diff @@
## dev #1969 +/- ##
============================================
+ Coverage 30.32% 30.32% +<.01%
+ Complexity 1370 1368 -2
============================================
Files 294 294
Lines 14999 14999
Branches 1806 1806
============================================
+ Hits 4548 4549 +1
+ Misses 10002 9998 -4
- Partials 449 452 +3
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed.
|
Contributor
|
+1 |
davidzollo
approved these changes
Feb 17, 2020
elonlo
pushed a commit
to fordeal-smalldata/incubator-dolphinscheduler
that referenced
this pull request
Jul 26, 2021
When create a new task or edit an exist task.The task details window will be open. Then if delete the task node or click the DataSource menu. And the task details window still open. The task details window should be close. # Conflicts: # dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Fix the bug #1968.
When create a new task or edit an exist task.The task details window will be open.
Then if delete the task node or click the DataSource menu. And the task details window still open.
For now, the task details window will be close.
Brief change log
Verify this pull request
This change added tests and can be verified as follows: