Skip to content

[DSIP-83][datasource-plugin] Add DolphinDB datasource#17404

Merged
SbloodyS merged 11 commits intoapache:devfrom
eco8848:Feature-15953
Aug 20, 2025
Merged

[DSIP-83][datasource-plugin] Add DolphinDB datasource#17404
SbloodyS merged 11 commits intoapache:devfrom
eco8848:Feature-15953

Conversation

@eco8848
Copy link
Copy Markdown
Contributor

@eco8848 eco8848 commented Aug 8, 2025 •
edited by SbloodyS
Loading

Purpose of the pull request

This pull request adds DolphinDB datasource.

close #16818

Brief change log

  • Added DolphinDB datasource module.
  • Added DolphinDB documentation.
  • Added DolphinDB constant definitions, connection parameters, data source processors and other components.
  • Added DolphinDB JDBC driver dependency.

Verify this pull request

This change added tests and can be verified as follows:

  • Added DataSourceUtilsTest class to test the datasource utility methods.
  • Added DolphinDBDataSourceChannelFactoryTest class to verify the creation methods of the datasource channel factory.
  • Added DolphinDBDataSourceChannelTest class to validate the creation of the datasource client through the channel.
  • Added DolphinDBDataSourceProcessorTest class to test various functionalities of the datasource processor.

@github-actions github-actions Bot added UI ui and front end related backend test document labels Aug 8, 2025
SbloodyS
SbloodyS reviewed Aug 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add api-test or e2e-test @eco8848

@eco8848
Copy link
Copy Markdown
Contributor Author

eco8848 commented Aug 11, 2025

Please add api-test or e2e-test @eco8848

I found that the Maven configuration issue was causing API-TEST and E2E-TEST to fail during the build process. I've fixed it, please re-run the workflow.

github-advanced-security[bot]
github-advanced-security AI found potential problems Aug 11, 2025
View reviewed changes
Comment thread .../apache/dolphinscheduler/plugin/datasource/dolphindb/param/DolphinDBDataSourceProcessor.java Dismissed
@eco8848 eco8848 requested a review from SbloodyS August 11, 2025 09:35
@SbloodyS
Copy link
Copy Markdown
Member

SbloodyS commented Aug 11, 2025

CI failed. And I did not find any relavent api-test or e2e-test code. Did you forget to commit it?

@github-actions github-actions Bot added the e2e e2e test label Aug 12, 2025
@eco8848
Copy link
Copy Markdown
Contributor Author

eco8848 commented Aug 12, 2025

CI failed. And I did not find any relavent api-test or e2e-test code. Did you forget to commit it?

Thanks for reviewing. I realize I forgot to include the e2e test file for this change. I’ve just pushed the missing file to the same branch.

@github-actions github-actions Bot added the CI&CD label Aug 12, 2025
@eco8848 eco8848 requested a review from SbloodyS August 12, 2025 07:29
@eco8848
[DS-15953][E2E][fix] Fix DolphinDB datasource E2E test failure caused…
3ea0428 
… by attempting to interact with hidden database input field
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 14, 2025

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SbloodyS
SbloodyS reviewed Aug 18, 2025
View reviewed changes
Comment thread ...dolphinscheduler-e2e-case/src/test/resources/docker/datasource-dolphindb/docker-compose.yaml Outdated
Comment thread tools/dependencies/known-dependencies.txt
@eco8848 eco8848 requested a review from SbloodyS August 19, 2025 02:17
SbloodyS
SbloodyS reviewed Aug 19, 2025
View reviewed changes
Comment thread docs/docs/en/guide/datasource/dolphindb.md Outdated
@eco8848 eco8848 requested a review from SbloodyS August 19, 2025 06:00
SbloodyS
SbloodyS approved these changes Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added this to the 3.3.1 milestone Aug 20, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 20, 2025

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SbloodyS SbloodyS merged commit 3dd1720 into apache:dev Aug 20, 2025
73 of 75 checks passed
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Aug 20, 2025

Awesome work, congrats on your first merged pull request!

@SbloodyS SbloodyS added the DSIP label Aug 22, 2025
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
@eco8848 @davidzollo
[DSIP-83][datasource-plugin] Add DolphinDB datasource (apache#17404)
222057b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@EricGao888 EricGao888 EricGao888 approved these changes

@songjianet songjianet Awaiting requested review from songjianet

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

@eco8848 eco8848

Labels

backend CI&CD document DSIP e2e e2e test first time contributor First-time contributor ready-to-merge test UI ui and front end related

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

[DSIP-83][Feature] Add DolphinDB datasource support to DolphinScheduler

5 participants

@eco8848 @SbloodyS @EricGao888 @github-advanced-security @HakukuMatata