Skip to content

[DSIP-90][Task] Add a gRPC task plugin#17402

Merged
SbloodyS merged 213 commits intoapache:devfrom
npofsi:subr
Oct 21, 2025
Merged

[DSIP-90][Task] Add a gRPC task plugin#17402
SbloodyS merged 213 commits intoapache:devfrom
npofsi:subr

Conversation

@npofsi
Copy link
Copy Markdown
Contributor

@npofsi npofsi commented Aug 7, 2025

Purpose of the pull request

This pull request adds an implementation for gRPC plugin which is introduced in DSIP-90. It provides an JSON api to transfer protobuf definitions between webpage and server.

Close #17290

Brief change log

BrowserSide:

  • Add gRPC plugin component in workflow space
  • Add gRPC plugin UI to accept Protobuf and messages
  • Translate definitions from Protobuf to JSON use protobuf.js
image image image

ServerSide:

  • Written a JSON Parser to reconstruct the Protobuf from browser side
  • Making gRPC call from server and check the response

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

Gallardot
Gallardot previously approved these changes Oct 18, 2025
Copy link
Copy Markdown
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhongjiajie
zhongjiajie previously approved these changes Oct 18, 2025
ruanwenjun
ruanwenjun previously approved these changes Oct 20, 2025
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npofsi npofsi dismissed stale reviews from ruanwenjun, zhongjiajie, and Gallardot via d12e772 October 20, 2025 03:02
@sonarqubecloud
Copy link
Copy Markdown

@SbloodyS SbloodyS modified the milestones: 3.3.2, 3.3.3 Oct 20, 2025
@npofsi npofsi requested a review from ruanwenjun October 21, 2025 05:09
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS changed the title [DSIP-90][Task] Add a gRPC task plugin [DSIP-90][Task] Add a gRPC task plugin Oct 21, 2025
@SbloodyS SbloodyS changed the title [DSIP-90][Task] Add a gRPC task plugin [DSIP-90][Task] Add a gRPC task plugin Oct 21, 2025
@SbloodyS SbloodyS merged commit 63f8aac into apache:dev Oct 21, 2025
93 of 99 checks passed
@npofsi npofsi deleted the subr branch October 22, 2025 03:01
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DSIP-90][Task] Add a gRPC task plugin

6 participants