Fix bug: Use try-with-resources or close this "Statement" in a "finally" clause.#1702
Merged
davidzollo merged 3 commits intoapache:devfrom Feb 6, 2020
Merged
Conversation
… in a "finally" clause.
Codecov Report
@@ Coverage Diff @@
## dev #1702 +/- ##
=========================================
+ Coverage 17.15% 23.66% +6.5%
=========================================
Files 285 299 +14
Lines 13900 14405 +505
Branches 2267 2374 +107
=========================================
+ Hits 2385 3409 +1024
+ Misses 11240 10605 -635
- Partials 275 391 +116
Continue to review full report at Codecov.
|
Contributor
Author
|
Quality Gate failed Failed condition B Maintainability Rating on New Code (is worse than A) |
Technoboy-
reviewed
Jan 17, 2020
| String value = rs.getString(i); | ||
| logger.info("{} \t", value); | ||
| } | ||
| logger.info(""); |
Technoboy-
reviewed
Jan 17, 2020
| } | ||
| } | ||
| } catch (SQLException e) { | ||
| logger.error(e.getMessage(),e); |
Contributor
There was a problem hiding this comment.
logger.error("SQLException", e);
Technoboy-
reviewed
Jan 17, 2020
| logger.error("Error executing: {}", sql); | ||
| throw e; | ||
| } catch (IOException e) { | ||
| e.fillInStackTrace(); |
Technoboy-
reviewed
Jan 17, 2020
| logger.error("Error executing: {}", command); | ||
| throw e; | ||
| } catch (IOException e) { | ||
| e.fillInStackTrace(); |
Technoboy-
reviewed
Jan 17, 2020
| while (rs.next()) { | ||
| for (int i = 0; i < cols; i++) { | ||
| String value = rs.getString(i); | ||
| logger.info("{} \t", value); |
Technoboy-
reviewed
Jan 17, 2020
| } | ||
| } | ||
| } catch (SQLException e) { | ||
| logger.error(e.getMessage(),e); |
Contributor
There was a problem hiding this comment.
logger.error("SQLException", e);
Contributor
Author
|
Roger |
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
#1701 Resources should be closed
Brief change log