Skip to content

[BUG] Fix bug: Use try-with-resources or close this "Statement" in a "finally" clause. #1701

@Jave-Chen

Description

@Jave-Chen

Describe the bug
Resources should be closed

Connections, streams, files, and other classes that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. Further, that close call must be made in a finally block otherwise an exception could keep the call from being made. Preferably, when class implements AutoCloseable, resource should be created using "try-with-resources" pattern and will be closed automatically.

Failure to properly close resources will result in a resource leak which could bring first the application and then perhaps the box it's on to their knees.

File
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ScriptRunner.java

SonarCloud Link
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9Pvj4rYzPBRjkobYxo&open=AW9Pvj4rYzPBRjkobYxo
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9Pvj4rYzPBRjkobYxq&open=AW9Pvj4rYzPBRjkobYxq
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9Pvj4rYzPBRjkobYxn&open=AW9Pvj4rYzPBRjkobYxn
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9Pvj4rYzPBRjkobYxp&open=AW9Pvj4rYzPBRjkobYxp

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions