Skip to content

Add FileUtilsTest.java , the unit test for FileUtils#1493

Merged
qiaozhanwei merged 1 commit intoapache:devfrom
nauu:newfeature/#1645-FileUtilsUT-4
Dec 17, 2019
Merged

Add FileUtilsTest.java , the unit test for FileUtils#1493
qiaozhanwei merged 1 commit intoapache:devfrom
nauu:newfeature/#1645-FileUtilsUT-4

Conversation

@nauu
Copy link
Copy Markdown
Contributor

@nauu nauu commented Dec 16, 2019

What is the purpose of the pull request

For #1465.

Add FileUtilsTest.java , the unit test for FileUtils.

Brief change log

  • Add /api/utils/FileUtilsTest.java to root pom.xml
  • Add FileUtilsTest.java

Verify this pull request

This change added tests and can be verified as follows:

  • Added FileUtilsTest to verify the change.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1493 into dev will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev   #1493      +/-   ##
========================================
+ Coverage   2.69%   2.78%   +0.08%     
========================================
  Files        271     271              
  Lines      13593   13593              
  Branches    2159    2159              
========================================
+ Hits         367     378      +11     
+ Misses     13209   13196      -13     
- Partials      17      19       +2
Impacted Files Coverage Δ
...g/apache/dolphinscheduler/api/utils/FileUtils.java 68.75% <0%> (+68.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e0562...45cbc73. Read the comment docs.

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 4cf8458 into apache:dev Dec 17, 2019
lenboo pushed a commit that referenced this pull request Dec 17, 2019
* add ZkServer for UT

* Add FileUtilsTest.java , the unit test for FileUtils (#1493) (#1)

* updates for reference ZkServer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants