Skip to content

[Feature][Data Quality] Data Quality Support Choose Database#14406

Merged
songjianet merged 14 commits intoapache:devfrom
qingwli:dataquality-support-choose-database
Jul 12, 2023
Merged

[Feature][Data Quality] Data Quality Support Choose Database#14406
songjianet merged 14 commits intoapache:devfrom
qingwli:dataquality-support-choose-database

Conversation

@qingwli
Copy link
Copy Markdown
Member

@qingwli qingwli commented Jun 26, 2023

@github-actions github-actions bot added backend UI ui and front end related labels Jun 26, 2023
@qingwli
Copy link
Copy Markdown
Member Author

qingwli commented Jun 26, 2023

PTAL @zixi0825

@SbloodyS SbloodyS added feature new feature 3.2.0 labels Jun 26, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jun 26, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 26, 2023 •
edited
Loading

Codecov Report

Merging #14406 (a9a5944) into dev (f186cd5) will increase coverage by 0.01%.
The diff coverage is 55.93%.

❗ Current head a9a5944 differs from pull request most recent head 15132b0. Consider uploading reports for the commit 15132b0 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14406      +/-   ##
============================================
+ Coverage     38.55%   38.57%   +0.01%     
- Complexity     4556     4564       +8     
============================================
  Files          1236     1237       +1     
  Lines         43456    43500      +44     
  Branches       4814     4819       +5     
============================================
+ Hits          16756    16779      +23     
- Misses        24842    24862      +20     
- Partials       1858     1859       +1
Impacted Files Coverage Δ
...scheduler/api/controller/DataSourceController.java 36.36% <0.00%> (-2.35%) ⬇️
...inscheduler/api/controller/ExecutorController.java 17.94% <ø> (ø)
...e/dolphinscheduler/common/constants/Constants.java 75.00% <ø> (ø)
.../dolphinscheduler/common/enums/ExecutionOrder.java 0.00% <0.00%> (ø)
...dolphinscheduler/dao/entity/TaskDefinitionLog.java 18.18% <0.00%> (-0.43%) ⬇️
.../plugin/task/api/parameters/K8sTaskParameters.java 0.00% <ø> (ø)
...er/plugin/task/api/utils/DataQualityConstants.java 0.00% <ø> (ø)
...i/service/impl/AlertPluginInstanceServiceImpl.java 63.86% <33.33%> (ø)
...phinscheduler/plugin/task/hivecli/HiveCliTask.java 37.80% <38.88%> (-7.48%) ⬇️
...eduler/api/service/impl/DataSourceServiceImpl.java 50.83% <58.33%> (+2.36%) ⬆️
... and 8 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented Jun 27, 2023

approval ci run

@qingwli qingwli requested a review from EricGao888 as a code owner June 27, 2023 05:58
zhongjiajie
zhongjiajie reviewed Jun 28, 2023
View reviewed changes
This was referenced Jun 28, 2023
Merged
Merged
@qingwli qingwli requested a review from Amy0104 as a code owner June 28, 2023 07:01
@SbloodyS SbloodyS changed the title [Feature][Data Quality] Data Quality Support Choose Dadabase [Feature][Data Quality] Data Quality Support Choose Database Jun 28, 2023
@zixi0825
Copy link
Copy Markdown
Member

zixi0825 commented Jul 3, 2023

Please increase the coverage of unit testing

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 6, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@qingwli
Copy link
Copy Markdown
Member Author

qingwli commented Jul 6, 2023

https://sonarcloud.io/summary/new_code?id=apache-dolphinscheduler&pullRequest=14406

@zixi0825
Copy link
Copy Markdown
Member

zixi0825 commented Jul 10, 2023

LGTM

@songjianet songjianet merged commit 175d976 into apache:dev Jul 12, 2023
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this pull request Jul 14, 2023
@qingwli
[Feature][Data Quality] Data Quality Support Choose Database (apache#…
3eb81d9 
…14406)

* add dataquality database api

* change ui

* api change

* update

* fix spotless

* fix h2

* fix pg

* fix-dead-line

* update

* fix-spotless

* update pg sql

* add ut

* fix ut
@qingwli qingwli deleted the dataquality-support-choose-database branch July 19, 2023 09:14
@qingwli qingwli mentioned this pull request Jul 20, 2023
Merged
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
@qingwli @zhongjiajie
[Feature][Data Quality] Data Quality Support Choose Database (#14406)
d414f26 
* add dataquality database api

* change ui

* api change

* update

* fix spotless

* fix h2

* fix pg

* fix-dead-line

* update

* fix-spotless

* update pg sql

* add ut

* fix ut

(cherry picked from commit 175d976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie left review comments

@Radeity Radeity Radeity left review comments

@songjianet songjianet songjianet approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@qingwli qingwli

Labels

backend document feature new feature UI ui and front end related

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Feature][Data Quality] Data Quality Support Choose Dadabase

7 participants

@qingwli @codecov-commenter @zhongjiajie @zixi0825 @songjianet @Radeity @SbloodyS