[Migrate][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in alert and api module#12337
Merged
EricGao888 merged 2 commits intoapache:devfrom Oct 13, 2022
Merged
[Migrate][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in alert and api module#12337EricGao888 merged 2 commits intoapache:devfrom
EricGao888 merged 2 commits intoapache:devfrom
Conversation
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/FileUtilsTest.java
Fixed
Show fixed
Hide fixed
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/FileUtilsTest.java
Fixed
Show fixed
Hide fixed
...test/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceTest.java
Fixed
Show fixed
Hide fixed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #12337 +/- ##
=========================================
Coverage 38.94% 38.94%
+ Complexity 4178 4175 -3
=========================================
Files 1040 1040
Lines 38797 38797
Branches 4460 4462 +2
=========================================
Hits 15109 15109
Misses 21919 21919
Partials 1769 1769 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Kudos, SonarCloud Quality Gate passed!
|
kezhenxu94
approved these changes
Oct 13, 2022
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
… and api module (apache#12337) * Migrate all UT cases from jUnit 4 to jUnit 5 in alert and api module * Fix potential problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request