[Improvement][Test] Remove the usage of powermock in datasource-plugin module#12194
Merged
EricGao888 merged 4 commits intoapache:devfrom Sep 30, 2022
Merged
[Improvement][Test] Remove the usage of powermock in datasource-plugin module#12194EricGao888 merged 4 commits intoapache:devfrom
EricGao888 merged 4 commits intoapache:devfrom
Conversation
c720741 to
3dd9a7f
Compare
| import org.apache.dolphinscheduler.spi.utils.PropertyUtils; | ||
| import org.apache.dolphinscheduler.spi.utils.StringUtils; | ||
|
|
||
| import sun.security.krb5.Config; |
Check notice
Code scanning / CodeQL
Access to unsupported JDK-internal API
Member
Author
There was a problem hiding this comment.
This is the order rearrangement by spotless, not new import added.
kezhenxu94
previously approved these changes
Sep 29, 2022
efb4bb2 to
d736c6b
Compare
Codecov Report
@@ Coverage Diff @@
## dev #12194 +/- ##
============================================
- Coverage 39.44% 39.44% -0.01%
+ Complexity 4142 4140 -2
============================================
Files 1011 1011
Lines 37845 37852 +7
Branches 4345 4347 +2
============================================
+ Hits 14929 14930 +1
- Misses 21185 21191 +6
Partials 1731 1731
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed. |
kezhenxu94
approved these changes
Sep 30, 2022
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…n module (apache#12194) * Remove the usage of powermock in datasource-plugin module * Switch datasource-plugin module to use PropertyUtils in common module
fuchanghai
pushed a commit
to fuchanghai/dolphinscheduler
that referenced
this pull request
Nov 16, 2022
…n module (apache#12194) * Remove the usage of powermock in datasource-plugin module * Switch datasource-plugin module to use PropertyUtils in common module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
commonmodule instead of that inspimodule.Verify this pull request