Skip to content

[Improvement-12144] Remove powermock in dolphinschduler-api#12169

Merged
kezhenxu94 merged 1 commit intoapache:devfrom
rickchengx:Improvement-12144
Sep 29, 2022
Merged

[Improvement-12144] Remove powermock in dolphinschduler-api#12169
kezhenxu94 merged 1 commit intoapache:devfrom
rickchengx:Improvement-12144

Conversation

@rickchengx
Copy link
Copy Markdown
Contributor

Purpose of the pull request

close: #12144

Brief change log

  • Removed powermock related code.
  • Removed redundant comments and useless test code.
  • Removed unnecessary stubbings.

Verify this pull request

Covered and verified by unit tests.

@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly test labels Sep 28, 2022
@EricGao888 EricGao888 added this to the 3.2.0 milestone Sep 28, 2022
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kezhenxu94 kezhenxu94 merged commit 57fafe4 into apache:dev Sep 29, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
fuchanghai pushed a commit to fuchanghai/dolphinscheduler that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Test] Remove Powermock in dolphinscheduler-api

3 participants