[Improvement][Test] Remove powermock in dolphinscheduler-master module#12143
Merged
EricGao888 merged 1 commit intoapache:devfrom Sep 26, 2022
Merged
[Improvement][Test] Remove powermock in dolphinscheduler-master module#12143EricGao888 merged 1 commit intoapache:devfrom
EricGao888 merged 1 commit intoapache:devfrom
Conversation
…comments, useless code and unnecessary stubbings
kezhenxu94
approved these changes
Sep 26, 2022
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #12143 +/- ##
============================================
+ Coverage 38.69% 39.04% +0.35%
- Complexity 4010 4078 +68
============================================
Files 1001 1010 +9
Lines 37422 37713 +291
Branches 4262 4330 +68
============================================
+ Hits 14480 14726 +246
- Misses 21295 21299 +4
- Partials 1647 1688 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Kudos, SonarCloud Quality Gate passed!
|
3 tasks
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
* Remove powermock related code in dolphinscheduler-master module * Remove redundant comments, useless code and unnecessary stubbings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Powermockindolphinscheduler-master#12124Brief change log
This PR did some code cleaning In dolphinscheduler-master module:
Verify this pull request