Skip to content

[Doc][Python] yaml_define examples link error #11817

Merged
SbloodyS merged 1 commit intoapache:devfrom
jieguangzhou:py-doc-fix
Sep 9, 2022
Merged

[Doc][Python] yaml_define examples link error #11817
SbloodyS merged 1 commit intoapache:devfrom
jieguangzhou:py-doc-fix

Conversation

@jieguangzhou
Copy link
Copy Markdown
Member

Purpose of the pull request

close: #11816

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 7, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.59%. Comparing base (6d460a3) to head (feb40d4).
⚠️ Report is 1754 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #11817   +/-   ##
=========================================
  Coverage     39.59%   39.59%           
- Complexity     4711     4713    +2     
=========================================
  Files          1016     1016           
  Lines         38139    38139           
  Branches       4259     4258    -1     
=========================================
  Hits          15101    15101           
- Misses        21420    21422    +2     
+ Partials       1618     1616    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

workflow code and want to migrate them to pydolphinscheduler.
- **YAML File**: We can use pydolphinscheduler CLI to create process using YAML file: :code:`pydolphinscheduler yaml -f tutorial.yaml`.
We can find more YAML file examples in `examples/yaml_define <https://github.com/apache/dolphinscheduler/tree/py-yaml/dolphinscheduler-python/pydolphinscheduler/examples/yaml_define>`_
We can find more YAML file examples in `examples/yaml_define <https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-python/pydolphinscheduler/examples/yaml_define>`_
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not use whole link in rst file, we should better use :ref: syntax for hyper link. Such as

You have to :ref:`install PyDolphinScheduler <start:installing pydolphinscheduler>` first before you using
is show

:ref:`install PyDolphinScheduler <start:installing pydolphinscheduler>`

Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added this to the 3.0.1 milestone Sep 9, 2022
@SbloodyS SbloodyS merged commit c41fa5a into apache:dev Sep 9, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Sep 10, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Sep 10, 2022
jieguangzhou added a commit to jieguangzhou/dolphinscheduler that referenced this pull request Sep 16, 2022
caishunfeng pushed a commit that referenced this pull request Sep 17, 2022
…AML configuration (#11988)

* [DSIP-11][python] create workflows from YAML configuration (#11611)

(cherry picked from commit 38ee91f)

* fix pydolphin yaml doc link (#11817)

(cherry picked from commit c41fa5a)
@zhongjiajie zhongjiajie modified the milestones: 3.0.1, 3.1.0 Sep 17, 2022
@zhongjiajie zhongjiajie added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 17, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document Pyscheduler release cherry-pick Mark this issue/PR had cherry-pick for release version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc][Python] yaml_define examples link error

4 participants