[Improvement][Test] Give an example on replacing Powermock with Mockito#11588
Merged
EricGao888 merged 9 commits intoapache:devfrom Sep 20, 2022
Merged
[Improvement][Test] Give an example on replacing Powermock with Mockito#11588EricGao888 merged 9 commits intoapache:devfrom
EricGao888 merged 9 commits intoapache:devfrom
Conversation
SbloodyS
reviewed
Aug 22, 2022
dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/pom.xml
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #11588 +/- ##
============================================
- Coverage 38.68% 38.66% -0.02%
+ Complexity 4006 4005 -1
============================================
Files 1002 1002
Lines 37213 37215 +2
Branches 4249 4251 +2
============================================
- Hits 14394 14390 -4
- Misses 21186 21190 +4
- Partials 1633 1635 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f404f38 to
1a627c8
Compare
caishunfeng
reviewed
Sep 8, 2022
...ter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterPropertyReader.java
Outdated
Show resolved
Hide resolved
...-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterTask.java
Outdated
Show resolved
Hide resolved
ff6357e to
c968f2f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
10 tasks
4 tasks
3 tasks
This was referenced Sep 26, 2022
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…to (apache#11588) * Give an example on replacing powermock with mockito * Remove redundant comments * Refactoring related UTs for better readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Give an example on replacing
PowermockwithMockito.Considering the workload, I'm not going to refactoring all the UTs which use
Powermockin one PR. This is an example as the beginning work of this issue. If the example looks good, I will have two more contributors finish the remaining work together with me.related: [Improvement][Test] Remove dependency of powermock #11405
Brief change log
Verify this pull request