Skip to content

[Bug] [API] The task priority and process instance priority might be null and cause NPE#11539

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fixProcessInstancePriorityMightBeNull
Aug 18, 2022
Merged

[Bug] [API] The task priority and process instance priority might be null and cause NPE#11539
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fixProcessInstancePriorityMightBeNull

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

Purpose of the pull request

close #11538

Brief change log

  • set default value in update scheduler interface
  • set default value in task_priority and process_instance_priority related table.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added this to the 3.0.1 milestone Aug 18, 2022
@SbloodyS SbloodyS added the bug Something isn't working label Aug 18, 2022
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #11539 (ee007ee) into dev (a974ba7) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head ee007ee differs from pull request most recent head 8ac7814. Consider uploading reports for the commit 8ac7814 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11539      +/-   ##
============================================
- Coverage     39.69%   39.66%   -0.04%     
+ Complexity     4696     4691       -5     
============================================
  Files           993      993              
  Lines         37692    37674      -18     
  Branches       4198     4190       -8     
============================================
- Hits          14962    14942      -20     
- Misses        21159    21164       +5     
+ Partials       1571     1568       -3     
Impacted Files Coverage Δ
...nscheduler/api/controller/SchedulerController.java 73.91% <ø> (ø)
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 43.54% <0.00%> (-6.46%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) ⬇️
...rver/master/runner/task/BlockingTaskProcessor.java 75.86% <0.00%> (-0.55%) ⬇️
...eduler/api/service/impl/DataSourceServiceImpl.java 27.90% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun merged commit 2862f5b into apache:dev Aug 18, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixProcessInstancePriorityMightBeNull branch August 18, 2022 08:21
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 19, 2022
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 20, 2022
zhuxt2015 pushed a commit to zhuxt2015/dolphinscheduler that referenced this pull request Aug 21, 2022
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 23, 2022
* Set process instance and task priority default value as 2 (apache#11539)

(cherry picked from commit 2862f5b)

* Fix submit dependent task failed doesn't catch exception
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 23, 2022
zhuangchong pushed a commit to zhuangchong/incubator-dolphinscheduler that referenced this pull request Sep 15, 2022
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 15, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working release cherry-pick Mark this issue/PR had cherry-pick for release version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API] The task priority and process instance priority might be null and cause NPE

4 participants