FYI, we could not have an empty line at the end of this file because it would cause Spotless to fail to parse the imports management rules.

If we hope to manage the import order, it's better to use the origin order

org.apache.dolphinscheduler,org.apache,java,javax,org,com

otherwise, the default order is still ok.

If we hope to manage the import order, it's better to use the origin order

org.apache.dolphinscheduler,org.apache,java,javax,org,com

otherwise, the default order is still ok.

Sure, I will give a try. If not work, will recover it.

@ruanwenjun Updated. It works well.

This removes the star import. But will it instead replaces the star import with the used specific class import? If not, this will cause compiling failed. Can you change a class with this example?

@kezhenxu94 diffplug/spotless#649 (comment) It is hardly possible for Spotless to replace with wildcards with specific imports, thus this is some kind of workaround actually. To prevent developers from pushing the commits without knowing that wildcards has been removed by their pre-commit hook, one possible solution is to add a message in pre-commit hook to inform them of this behavior. WDYT?

@kezhenxu94 FYI, I also added a comment in the origin issue to seek help to see if there is some good practice to handle wildcard imports with Spotless: diffplug/spotless#649 (comment)

@kezhenxu94 FYI, I also added a comment in the origin issue to seek help to see if there is some good practice to handle wildcard imports with Spotless: diffplug/spotless#649 (comment)

Wow. The issue has been 2 years...

This removes the star import. But will it instead replaces the star import with the used specific class import? If not, this will cause compiling failed. Can you change a class with this example?

@kezhenxu94 Just a follow-up, as I've tested it locally, if we use mvn spotless:check instead of mvn spotless:apply, it only blocks the wildcard imports without removing them. To improve, we could change the pre-commit hook from mvn spotless:apply to mvn spotless:check and add an output message to inform contributors that they should remove wildcard imports. WDYT?

This removes the star import. But will it instead replaces the star import with the used specific class import? If not, this will cause compiling failed. Can you change a class with this example?

@kezhenxu94 Just a follow-up, as I've tested it locally, if we use mvn spotless:check instead of mvn spotless:apply, it only blocks the wildcard imports without removing them. To improve, we could change the pre-commit hook from mvn spotless:apply to mvn spotless:check and add an output message to inform contributors that they should remove wildcard imports. WDYT?

Can you identify the failure of spotless:check is because of wildcard imports or other code style issues?

@kezhenxu94 Yes, I just double-checked it. To reproduce, you might change

@kezhenxu94 Yes, I just double-checked it. To reproduce, you might change

dolphinscheduler/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTask.java

Lines 33 to 35 in 68316f6

	import java.util.HashMap;
	import java.util.List;
	import java.util.Map;

to import java.util.*; and run mvn spotless:check.

How can yo tell the spotless:check failure is because of wildcard import, if I have other code style issues and no wildcard import?

@kezhenxu94 Yes, I just double-checked it. To reproduce, you might change

dolphinscheduler/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTask.java

Lines 33 to 35 in 68316f6

	import java.util.HashMap;
	import java.util.List;
	import java.util.Map;

to import java.util.*; and run mvn spotless:check.

How can yo tell the spotless:check failure is because of wildcard import, if I have other code style issues and no wildcard import?

Good question, since each rule has its name, I think there might be a way to configure Spotless to explicitly tell which rule the code fails. I will take a look and see if there is a way to do so.