Skip to content

Set master's task running status in runTask to avoid the task group acquire failed, but the task status is in running#11451

Merged
caishunfeng merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_moveTaskRunningInMasterTask
Aug 13, 2022
Merged

Set master's task running status in runTask to avoid the task group acquire failed, but the task status is in running#11451
caishunfeng merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_moveTaskRunningInMasterTask

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

… acquire failed, but the task status is in running
@ruanwenjun ruanwenjun added this to the 3.0.1 milestone Aug 12, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 12, 2022

Codecov Report

❌ Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.55%. Comparing base (e3c6ace) to head (455849d).
⚠️ Report is 1860 commits behind head on dev.

Files with missing lines Patch % Lines
...server/master/runner/task/SwitchTaskProcessor.java 0.00% 7 Missing ⚠️
...ver/master/runner/task/ConditionTaskProcessor.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #11451   +/-   ##
=========================================
  Coverage     39.55%   39.55%           
  Complexity     4628     4628           
=========================================
  Files           980      980           
  Lines         37282    37281    -1     
  Branches       4180     4182    +2     
=========================================
+ Hits          14747    14748    +1     
+ Misses        20987    20985    -2     
  Partials       1548     1548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

23.5% 23.5% Coverage
43.5% 43.5% Duplication

@caishunfeng
Copy link
Copy Markdown
Contributor

It seems miss the SubProcess Task and Switch Task handle.

@ruanwenjun
Copy link
Copy Markdown
Member Author

It seems miss the SubProcess Task and Switch Task handle.

The Switch has been changed, and SubProcess is already currect.

@caishunfeng caishunfeng merged commit 0558960 into apache:dev Aug 13, 2022
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Aug 18, 2022
… acquire failed, but the task status is in running (apache#11451)

(cherry picked from commit 0558960)
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Aug 18, 2022
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Sep 17, 2022
… acquire failed, but the task status is in running (apache#11451)

(cherry picked from commit 0558960)
ruanwenjun added a commit that referenced this pull request Sep 17, 2022
… acquire failed, but the task status is in running (#11451) (#12011)

(cherry picked from commit 0558960)
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 19, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
… acquire failed, but the task status is in running (apache#11451)
@ruanwenjun ruanwenjun deleted the dev_wenjun_moveTaskRunningInMasterTask branch December 2, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend release cherry-pick Mark this issue/PR had cherry-pick for release version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants