[hotfix] Fix workflow instance may failover many times due to doesn't check the restart time#11445
Merged
ruanwenjun merged 1 commit intoapache:devfrom Aug 12, 2022
Conversation
a5edb60 to
4b7f0f0
Compare
Codecov Report
@@ Coverage Diff @@
## dev #11445 +/- ##
============================================
- Coverage 39.55% 39.53% -0.02%
- Complexity 4628 4630 +2
============================================
Files 980 980
Lines 37282 37288 +6
Branches 4180 4182 +2
============================================
- Hits 14747 14742 -5
- Misses 20987 20996 +9
- Partials 1548 1550 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Aug 13, 2022
…e restart time (apache#11445) (cherry picked from commit 0ca3086)
caishunfeng
pushed a commit
to caishunfeng/dolphinscheduler
that referenced
this pull request
Aug 18, 2022
…e restart time (apache#11445) (apache#38) (cherry picked from commit 0ca3086)
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Sep 17, 2022
…e restart time (apache#11445) (cherry picked from commit 0ca3086)
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
If there exist a workflow instance start at 9:00.
and it failover at 10:00, the master is start at 10:00, then the workflow instance may be failover many times.
Since we didn't check the restart time, and the failover workflow instance only change it's restart time
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md