Skip to content

[Fix-11413] Cannot set task status to kill if the task is not in running.#11414

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fixStop
Aug 11, 2022
Merged

[Fix-11413] Cannot set task status to kill if the task is not in running.#11414
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fixStop

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

Purpose of the pull request

close #11413

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 11, 2022

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.49%. Comparing base (0464123) to head (714a099).
⚠️ Report is 1872 commits behind head on dev.

Files with missing lines Patch % Lines
...server/master/runner/task/CommonTaskProcessor.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #11414      +/-   ##
============================================
+ Coverage     39.44%   39.49%   +0.04%     
- Complexity     4608     4617       +9     
============================================
  Files           980      980              
  Lines         37149    37195      +46     
  Branches       4142     4155      +13     
============================================
+ Hits          14655    14689      +34     
- Misses        20982    20986       +4     
- Partials       1512     1520       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added the bug Something isn't working label Aug 11, 2022
@SbloodyS SbloodyS added this to the 3.0.1 milestone Aug 11, 2022
@ruanwenjun ruanwenjun merged commit 496c2d4 into apache:dev Aug 11, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixStop branch August 11, 2022 05:38
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 12, 2022
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Sep 17, 2022
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Sep 17, 2022
@caishunfeng caishunfeng added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 17, 2022
caishunfeng pushed a commit that referenced this pull request Sep 17, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working release cherry-pick Mark this issue/PR had cherry-pick for release version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Cannot set task status to kill if the task is not in running.

4 participants