Skip to content

Support reading application properties from kubernetes config map#11402

Merged
kezhenxu94 merged 1 commit intodevfrom
k8s/config
Aug 16, 2022
Merged

Support reading application properties from kubernetes config map#11402
kezhenxu94 merged 1 commit intodevfrom
k8s/config

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

This is a task from DolphinScheduler Operator, which should be more native in Kubernetes environment to reload the configurations of Spring.

@kezhenxu94 kezhenxu94 force-pushed the k8s/config branch 7 times, most recently from dbdb695 to 9d0d419 Compare August 15, 2022 02:32
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 15, 2022

Codecov Report

❌ Patch coverage is 36.36364% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.35%. Comparing base (13d400c) to head (94612ee).
⚠️ Report is 1839 commits behind head on dev.

Files with missing lines Patch % Lines
...lphinscheduler/plugin/task/api/utils/K8sUtils.java 0.00% 21 Missing ⚠️
...uler/plugin/task/api/k8s/impl/K8sTaskExecutor.java 54.54% 20 Missing ⚠️
...nscheduler/service/process/ProcessServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #11402      +/-   ##
============================================
- Coverage     39.36%   39.35%   -0.01%     
+ Complexity     4632     4629       -3     
============================================
  Files           987      987              
  Lines         37566    37570       +4     
  Branches       4183     4184       +1     
============================================
- Hits          14788    14787       -1     
- Misses        21227    21232       +5     
  Partials       1551     1551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kezhenxu94 kezhenxu94 marked this pull request as ready for review August 15, 2022 09:46
@kezhenxu94
Copy link
Copy Markdown
Member Author

This is PR is ready to merge, @caishunfeng @SbloodyS @ruanwenjun mind taking a look?

Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added the feature new feature label Aug 15, 2022
@SbloodyS SbloodyS added this to the 3.1.0 milestone Aug 15, 2022
@kezhenxu94 kezhenxu94 merged commit f6ef628 into dev Aug 16, 2022
@kezhenxu94 kezhenxu94 deleted the k8s/config branch August 16, 2022 12:25
zhuxt2015 pushed a commit to zhuxt2015/dolphinscheduler that referenced this pull request Aug 21, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants