Skip to content

Add isSuccess in loop task status to judge the task success or failuer#11169

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_addSuccessInLoopTaskStatus
Jul 28, 2022
Merged

Add isSuccess in loop task status to judge the task success or failuer#11169
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_addSuccessInLoopTaskStatus

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

Purpose of the pull request

Fix #11137

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addSuccessInLoopTaskStatus branch from 2d39fc2 to c0f96b1 Compare July 27, 2022 08:27
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addSuccessInLoopTaskStatus branch from c0f96b1 to a572926 Compare July 27, 2022 08:28
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #11169 (a572926) into dev (d76d6da) will decrease coverage by 0.26%.
The diff coverage is 16.91%.

@@             Coverage Diff              @@
##                dev   #11169      +/-   ##
============================================
- Coverage     40.49%   40.23%   -0.27%     
- Complexity     4887     4926      +39     
============================================
  Files           951      982      +31     
  Lines         37201    37567     +366     
  Branches       4080     4128      +48     
============================================
+ Hits          15065    15114      +49     
- Misses        20613    20917     +304     
- Partials       1523     1536      +13     
Impacted Files Coverage Δ
...erver/master/event/TaskRetryStateEventHandler.java 0.00% <0.00%> (ø)
...ler/server/master/event/TaskStateEventHandler.java 0.00% <0.00%> (ø)
...ver/master/event/TaskTimeoutStateEventHandler.java 0.00% <0.00%> (ø)
...server/master/event/WorkflowStartEventHandler.java 0.00% <0.00%> (ø)
...server/master/event/WorkflowStateEventHandler.java 0.00% <0.00%> (ø)
...master/event/WorkflowTimeoutStateEventHandler.java 0.00% <0.00%> (ø)
.../server/master/runner/WorkflowExecuteRunnable.java 7.79% <0.00%> (ø)
...dolphinscheduler/plugin/task/api/AbstractTask.java 0.00% <ø> (ø)
...olphinscheduler/plugin/task/api/TaskConstants.java 0.00% <0.00%> (ø)
...ler/plugin/task/api/loop/BaseLoopTaskExecutor.java 0.00% <0.00%> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ruanwenjun
Copy link
Copy Markdown
Member Author

@caishunfeng Please take a look.

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 052ceaa into apache:dev Jul 28, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_addSuccessInLoopTaskStatus branch July 28, 2022 04:12
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 1, 2022
@zhongjiajie zhongjiajie added this to the 3.1.0-alpha milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants