[Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.QueueController#11154
Merged
SbloodyS merged 19 commits intoapache:devfrom Aug 10, 2022
Merged
[Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.QueueController#11154SbloodyS merged 19 commits intoapache:devfrom
SbloodyS merged 19 commits intoapache:devfrom
Conversation
added 12 commits
July 18, 2022 15:49
Codecov Report
@@ Coverage Diff @@
## dev #11154 +/- ##
============================================
+ Coverage 40.17% 40.20% +0.02%
- Complexity 4950 4975 +25
============================================
Files 988 998 +10
Lines 37712 37773 +61
Branches 4145 4145
============================================
+ Hits 15151 15185 +34
- Misses 21021 21048 +27
Partials 1540 1540
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Contributor
Author
|
@SbloodyS @caishunfeng PTAL, thx. |
Member
|
Hi @tracehh , please split the service part and the v2 controller/entity part into two PR based on the above conclusions in #10998 (comment). Thanks. |
|
SonarCloud Quality Gate failed. |
Contributor
Author
|
ok,split the service part and the v2 controller/entity @SbloodyS |
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…eueController (apache#11154) * [Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.QueueController
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #11067
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: