Skip to content

[Fix-10918] Close datasource when expire from guava cache#11120

Merged
ruanwenjun merged 3 commits intoapache:devfrom
ruanwenjun:dev_wenjun_patch10918
Jul 23, 2022
Merged

[Fix-10918] Close datasource when expire from guava cache#11120
ruanwenjun merged 3 commits intoapache:devfrom
ruanwenjun:dev_wenjun_patch10918

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun commented Jul 23, 2022 •
edited
Loading

Purpose of the pull request

If the

close #10918

Brief change log

  • Add remove listener for guava cache
  • Close Datasource when DataSourceClient close.
  • Remove extra datasource in HiveDataSourceClient

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@ruanwenjun ruanwenjun requested a review from caishunfeng as a code owner July 23, 2022 08:48
@ruanwenjun ruanwenjun mentioned this pull request Jul 23, 2022
Closed
3 tasks
@ruanwenjun ruanwenjun added this to the 3.0.0-release milestone Jul 23, 2022
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_patch10918 branch from 518f401 to 6d10d6c Compare July 23, 2022 08:54
@SbloodyS SbloodyS added the bug Something isn't working label Jul 23, 2022
SbloodyS
SbloodyS approved these changes Jul 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 23, 2022 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.34%. Comparing base (952aee8) to head (9346fda).
⚠️ Report is 1967 commits behind head on dev.

Files with missing lines Patch % Lines
...atasource/api/plugin/DataSourceClientProvider.java 0.00% 9 Missing ⚠️
.../datasource/api/client/CommonDataSourceClient.java 0.00% 3 Missing ⚠️
...r/plugin/datasource/hive/HiveDataSourceClient.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #11120      +/-   ##
============================================
- Coverage     40.35%   40.34%   -0.01%     
+ Complexity     4874     4872       -2     
============================================
  Files           950      950              
  Lines         37184    37187       +3     
  Branches       4077     4079       +2     
============================================
- Hits          15005    15004       -1     
- Misses        20669    20673       +4     
  Partials       1510     1510

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun merged commit 71cf7e1 into apache:dev Jul 23, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_patch10918 branch July 23, 2022 12:43
caishunfeng pushed a commit that referenced this pull request Jul 27, 2022
@ruanwenjun @caishunfeng
[Fix-10918] Close datasource when expire from guava cache (#11120)
b791e91 
* Close datasource when expire from guava cache
* Remove duplicate datasource in HiveDataSourceClient
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 4, 2022
@ruanwenjun
[Fix-10918] Close datasource when expire from guava cache (apache#11120)
c19970c 
* Close datasource when expire from guava cache
* Remove duplicate datasource in HiveDataSourceClient

(cherry picked from commit 71cf7e1)
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 12, 2022
@ruanwenjun
[Fix-10918] Close datasource when expire from guava cache (apache#11120…
bd5aa78 
…) (apache#33)

* Close datasource when expire from guava cache
* Remove duplicate datasource in HiveDataSourceClient

(cherry picked from commit 71cf7e1)
@ruanwenjun ruanwenjun mentioned this pull request Aug 19, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@ruanwenjun ruanwenjun

Labels

backend bug Something isn't working

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

[Bug] [DataSource] MySQL Connection number increasing

3 participants

@ruanwenjun @codecov-commenter @SbloodyS