Skip to content

[bug][task-plugins]fix switch class name and add param check to the switch task plugin#10894

Merged
caishunfeng merged 4 commits intoapache:devfrom
Tianqi-Dotes:fix/switch
Jul 12, 2022
Merged

[bug][task-plugins]fix switch class name and add param check to the switch task plugin#10894
caishunfeng merged 4 commits intoapache:devfrom
Tianqi-Dotes:fix/switch

Conversation

@Tianqi-Dotes
Copy link
Copy Markdown
Member

Purpose of the pull request

close #

Brief change log

  1. change the subprocess class code name to switch
  2. add validations to default next node existence
  3. add validations to conditions to check when there is condition there must have next node

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Manually verified the change by testing locally.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
6.8% 6.8% Duplication

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 499e5b1 into apache:dev Jul 12, 2022
zhongjiajie pushed a commit to zhongjiajie/dolphinscheduler that referenced this pull request Jul 12, 2022
…witch task plugin (apache#10894)

* fix switch class name and add param check to the switch task plugin
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jul 18, 2022
…witch task plugin (apache#10894)

* fix switch class name and add param check to the switch task plugin
ruanwenjun pushed a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 1, 2022
…witch task plugin (apache#10894) (apache#24)

* fix switch class name and add param check to the switch task plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [SWITCH-PLUGIN] Switch task plugin wrong class name and no param validation

2 participants