Skip to content

[Fix-10666] Workflow submit failed will still in memory and never retry#10667

Merged
ruanwenjun merged 4 commits intoapache:devfrom
ruanwenjun:dev_wenjun_handleSubmitWorkflowFailed
Jul 4, 2022
Merged

[Fix-10666] Workflow submit failed will still in memory and never retry#10667
ruanwenjun merged 4 commits intoapache:devfrom
ruanwenjun:dev_wenjun_handleSubmitWorkflowFailed

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun commented Jun 29, 2022

Purpose of the pull request

close #10666

Brief change log

  • Add a daemon thread to retry the submit failed processInstance

@SbloodyS SbloodyS added backend bug Something isn't working labels Jun 29, 2022
@SbloodyS SbloodyS added this to the 3.0.0-beta-3 milestone Jun 29, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 29, 2022 •
edited
Loading

Codecov Report

Merging #10667 (a5b8146) into dev (75581b7) will decrease coverage by 0.06%.
The diff coverage is 2.96%.

@@             Coverage Diff              @@
##                dev   #10667      +/-   ##
============================================
- Coverage     40.90%   40.83%   -0.07%     
+ Complexity     4830     4828       -2     
============================================
  Files           897      899       +2     
  Lines         36157    36196      +39     
  Branches       4006     4014       +8     
============================================
- Hits          14789    14780       -9     
- Misses        19897    19938      +41     
- Partials       1471     1478       +7
Impacted Files Coverage Δ
...duler/server/master/exception/MasterException.java 0.00% <0.00%> (ø)
.../server/master/metrics/ProcessInstanceMetrics.java 59.37% <0.00%> (-3.96%) ⬇️
...r/server/master/runner/MasterSchedulerService.java 0.00% <0.00%> (ø)
.../server/master/runner/StateWheelExecuteThread.java 0.46% <0.00%> (-0.01%) ⬇️
...ler/server/master/runner/WorkflowSubmitStatue.java 0.00% <0.00%> (ø)
.../server/master/runner/WorkflowExecuteRunnable.java 7.00% <7.27%> (-0.76%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75581b7...a5b8146. Read the comment docs.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_handleSubmitWorkflowFailed branch 3 times, most recently from 20e5111 to 62865a0 Compare June 29, 2022 11:43
@ruanwenjun ruanwenjun requested a review from caishunfeng June 29, 2022 15:56
caishunfeng
caishunfeng previously approved these changes Jul 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng
Copy link
Copy Markdown
Contributor

caishunfeng commented Jul 4, 2022

Hi @ruanwenjun please resolve the conflicts.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_handleSubmitWorkflowFailed branch from 62865a0 to 5e5903d Compare July 4, 2022 01:56
@ruanwenjun
Copy link
Copy Markdown
Member Author

ruanwenjun commented Jul 4, 2022

@lenboo

@ruanwenjun ruanwenjun requested a review from caishunfeng July 4, 2022 02:14
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

SbloodyS
SbloodyS approved these changes Jul 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit 35a10d0 into apache:dev Jul 4, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_handleSubmitWorkflowFailed branch July 4, 2022 14:08
zhongjiajie pushed a commit to zhongjiajie/dolphinscheduler that referenced this pull request Jul 5, 2022
@ruanwenjun @zhongjiajie
[Fix-10666] Workflow submit failed will still in memory and never ret…
d8d026f 
…ry (apache#10667)

* Workflow submit failed will still in memory and never retry
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Jul 12, 2022
@ruanwenjun
[Fix-10666] Workflow submit failed will still in memory and never ret…
0214800 
…ry (apache#10667) (apache#12)

* Workflow submit failed will still in memory and never retry

Signed-off-by: Wenjun Ruan <wenjun@apache.org>
ruanwenjun added a commit that referenced this pull request Jul 19, 2022
@ruanwenjun
[Fix-10666] Workflow submit failed will still in memory and never ret…
3b923e5 
…ry (#10667)

* Workflow submit failed will still in memory and never retry

(cherry picked from commit 35a10d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@ruanwenjun ruanwenjun

Labels

backend bug Something isn't working

Projects

DolphinScheduler Roadmap
Archived in project

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Workflow submit failed will still in memory and never retry

4 participants

@ruanwenjun @codecov-commenter @caishunfeng @SbloodyS